Bug 10283 - Hide "many items" on second tab when using OpacSeparateHoldings
Summary: Hide "many items" on second tab when using OpacSeparateHoldings
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 7674
Blocks: 11255
  Show dependency tree / graph
 
Reported: 2013-05-19 09:45 UTC by Magnus Enger
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings (3.00 KB, patch)
2013-05-20 08:04 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings (3.04 KB, patch)
2013-06-03 00:24 UTC, Srdjan Jankovic 		Details | Diff | Splinter Review
[PASSED QA] Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings (3.16 KB, patch)
2013-06-16 16:40 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2013-05-19 09:45:21 UTC 
As noted by Katrin on Bug 7674:

"- if there are over 50 items in the holdings or Other holdings tab, the
  warning and link 'This record has many physical items. Click here
  to view them all.' is only shown for the first tab."

If there are more than a given number of items, they do not display directly in the detail view in the OPAC, but the text and link "This record has many physical items. Click here to view them all." is displayed instead. Activating OpacSeparateHoldings separates holdings into two tabs. If there are manye items the text and link is shown on the first tab (showing the items that belong to the library of the logged in suer), but the second tab (showing items at all other libraries) show the full list, not the text and link. This makes the initial display of the detail page veeery slow, when there are a lot if items (I have tested with ~3000 items).
Comment 1 Jonathan Druart 2013-05-20 08:04:57 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2013-06-03 00:24:54 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-06-16 16:40:06 UTC 
Created attachment 19043 [details] [review]
[PASSED QA] Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings

If there are over 50 items in the holdings or Other holdings tab, the
warning and link 'This record has many physical items. Click here to
view them all.' is only shown for the first tab.

Test plan:
- Switch on the OpacSeparateHoldings pref.
- Go on a biblio detail page at the OPAC with more than 50 items
- Check that the 'view all' link appears on the second tab.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.
Comment 4 Galen Charlton 2013-10-31 16:54:24 UTC 
Pushed to master.  Thanks, Jonathan!
Comment 5 Tomás Cohen Arazi (tcohen) 2013-12-05 18:28:46 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Jonathan!