The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not.
Created attachment 18841 [details] [review] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail
Created attachment 18842 [details] [review] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail
Created attachment 19203 [details] [review] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Who on the QA team (except for Chris and Kyle) knows how to test SIP or can teach me?
Hi Kyle, I am working on testing the SIP2 patches - it would speed things up quite a bit if you could provide me with a test script or some example SIP messages for placing holds. For an example of a test script see bug 10817.
FAIL C4/SIP/ILS.pm OK pod OK forbidden patterns FAIL valid Compilation failed in require Global symbol "$self" requires explicit package name OK critic FAIL C4/SIP/ILS/Patron.pm OK pod OK forbidden patterns FAIL valid C4/SIP/ILS/Patron.pm had compilation errors. Global symbol "$self" requires explicit package name OK critic
Created attachment 22143 [details] [review] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference - QA Followup
Created attachment 22145 [details] [review] [PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 22146 [details] [review] [PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds ( terrible naming on this one ). However, although the Koha OPAC respects this preference, placing holds via a SIP2 device will not. Test Plan: 1) Set maxoutstanding to $10 2) Pick a patron owning more than $10 in fees 3) Attempt to place a hold for this patron from a SIP2 device This attempt should succeed 4) Apply this patch 5) Restart your SIP2 server 6) Attempt to place a hold for this patron from a SIP2 device again This attempt should now fail Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 22147 [details] [review] [PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system preference - QA Followup Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Followup to failed QA tests have helped pass.
Pushed to master. Thanks, Kyle!
This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Kyle!