The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well.
Created attachment 18846 [details] [review] Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail
Got fatal: sha1 information is lacking or useless (C4/SIP/ILS/Patron.pm). Repository lacks necessary blobs to fall back on 3-way merge. when applying
Created attachment 19903 [details] [review] [SIGNED-OFF] Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
I'm ashamed to admit that I do not know how .po files get generated, so I assume nothing needs to be done there.
Hi Srdjan, po files are generated by running the translate script in misc/translator. For system preferences nothing much has to be done - you just have to make sure description in the .pref file makes sense. The scripts will make the file translatable :)
Kyle, the patch does not apply anymore against master: fatal: sha1 information is lacking or useless (C4/SIP/ILS/Patron.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Maybe it is caused by the sysprefs.sql file. Could you try to rebase it please?
Oops, I missed the dependency!
Since this patch is easy to test, maybe it would be better to change the dependency. Making bug 10445 depends on this one will allow to pass qa it.
CONFLICT (content): Merge conflict in C4/SIP/ILS/Patron.pm
Created attachment 26618 [details] [review] [SIGNED-OFF] Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
git grep maxoutstanding returns circ/offline.pl:$template->{'VARS'}->{'maxoutstanding'} = circ/offline.pl: C4::Context->preference('maxoutstanding') || 0; koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt: if (parseInt(patron.fine) > [% maxoutstanding %]) { They should be fixed too.
Created attachment 30239 [details] [review] Bug 10446 - Follow up fix As per comment #11 by Jonathan Druart, I just fixed the items in question. Plus, I noted a typographical error in the updatedatabase.pl message (10466 vs. 10446) TEST PLAN --------- 1) Apply the patch 2) Ensure the Circulation system preference, AllowOfflineCirculation, is enabled. 3) Home -> Circulation -> Built-in offline circulation interface
Created attachment 30240 [details] [review] Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail Rebased by Mark Tompsett Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 30241 [details] [review] Bug 10446 - Follow up fix As per comment #11 by Jonathan Druart, I just fixed the items in question. Plus, I noted a typographical error in the updatedatabase.pl message (10466 vs. 10446) TEST PLAN --------- 1) Apply the patch 2) Ensure the Circulation system preference, AllowOfflineCirculation, is enabled. 3) Home -> Circulation -> Built-in offline circulation interface
Sorry for an incomplete test plan, but I'm not sure how to use the offline circulation. But it should be similar to steps 2-6 elsewhere.
Created attachment 32757 [details] [review] Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 32758 [details] [review] Bug 10446 - Follow up fix As per comment #11 by Jonathan Druart, I just fixed the items in question. Plus, I noted a typographical error in the updatedatabase.pl message (10466 vs. 10446) TEST PLAN --------- 1) Apply the patch 2) Ensure the Circulation system preference, AllowOfflineCirculation, is enabled. 3) Home -> Circulation -> Built-in offline circulation interface
Rebased, but I'm still lacking a complete test plan, so I'll leave it as Failed QA.