Bug 10468 - Add pending holds to summary print
Summary: Add pending holds to summary print
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-14 12:14 UTC by Nicole C. Engard
Modified: 2017-06-14 22:05 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10468: Adding holds table to summary print (3.89 KB, patch)
2015-08-20 06:30 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 10468: Fix for qa tools (1.85 KB, patch)
2015-09-01 04:19 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 10468: Adding holds table to summary print (4.05 KB, patch)
2015-11-27 21:00 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
[PASSED QA] Bug 10468: Adding holds table to summary print (4.11 KB, patch)
2015-12-01 00:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-06-14 12:14:32 UTC
It would be nice if when you chose 'print summary' on the patron record it was more of a summary. If it showed the holds the patron had pending along with their checkouts and maybe even the total outstanding they have in fines.
Comment 1 Aleisha Amohia 2015-08-14 03:53:34 UTC
In version 3.21 of Koha, print summary shows checkouts and outstanding fines but not holds, so will work out how to put this in.
Comment 2 Aleisha Amohia 2015-08-20 06:30:18 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2015-08-31 10:15:49 UTC
Patch works as expected but qa tools complain about forbidden patterns:

 FAIL	members/summary-print.pl
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 131)
		forbidden pattern: trailing space char (line 138)
		forbidden pattern: tab char (line 130)
		forbidden pattern: tab char (line 134)
		forbidden pattern: tab char (line 133)
		forbidden pattern: trailing space char (line 135)
		forbidden pattern: trailing space char (line 137)
		forbidden pattern: trailing space char (line 140)
		forbidden pattern: tab char (line 132)

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 90)
Comment 4 Aleisha Amohia 2015-09-01 04:19:48 UTC Comment hidden (obsolete)
Comment 5 Héctor Eduardo Castro Avalos 2015-11-27 21:00:14 UTC Comment hidden (obsolete)
Comment 6 Héctor Eduardo Castro Avalos 2015-11-27 21:10:02 UTC
(In reply to Aleisha Amohia from comment #4)
> Created attachment 42133 [details] [review] [review]
> Bug 10468: Fix for qa tools
> 
> Hopefully this gets rid of those complaints!

Hi Aleisha

I squashed the two patches and I've signed-off also patches did not apply due the changes introduced by Bug 15068, but i fixed it up.

Regards
Comment 7 Katrin Fischer 2015-12-01 00:07:29 UTC
Created attachment 45250 [details] [review]
[PASSED QA] Bug 10468: Adding holds table to summary print

To test:
1) Add a hold to a patron
2) Go to patron page
3) Click Print Summary
4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Jesse Weaver 2015-12-30 23:14:47 UTC
Pushed to master. Fixed a bit of inconsistent indentation, please take note for the future.

Thanks for your contribution!