I have had at least 3 libraries totally miss the "add" link when adding an item to an order in acquisitions, which I take as a sign that it should be made bigger.
Created attachment 19274 [details] [review] Bug 10514 - make the add item link more noticeable when adding items to orders it was so small. People were missing it all the time! To test: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now.
Created attachment 19504 [details] [review] Bug 10514 - make the add item link more noticeable when adding items to orders it was so small. People were missing it all the time! To test: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
*** Bug 9539 has been marked as a duplicate of this bug. ***
Created attachment 19531 [details] screenshot Hi Liz, I totally agree that we need the links to stand out more, but I am not sold on the idea to make the font bigger. With the CSS in the top of the page it's also hard to change it back if you wanted to. Maybe we could use buttons? Another problem I spotted while looking at this bit of code: as it stands right now, those links are not translatable! It's a problem before and after your patch and can go onto another bug. But if you want to try - using a concatenated Javascript string with _() in the right place should fix it. But failing for wrong capitalization - sorry!
I don't like buttons there, that's not the end of the page and it just feels weird to me. The CSS is in the staff global css file, so not sure what you're getting at? As for it not being translatable - that predates this patch. Maybe I'll fix it though. For now, I'll probably just fix the capitalisation. ;) Liz
Created attachment 19536 [details] [review] Bug 10514 - make the add item link more noticeable when adding items to orders it was so small. People were missing it all the time! To test: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Follow up for translation and capitalisation. Probably deserves another sign off.
You are right about the CSS - sorry!
Created attachment 19571 [details] [review] Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item.
Created attachment 19583 [details] [review] Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Liz Rea <liz@catalyst.net.nz> I still feel weird about the button, but as two people have said they'd rather have the button, I'm alright with it I guess. Really what I want is people to notice it's there and click it at the appropriate time. I hope this will help that issue.
Created attachment 19585 [details] [review] [PASSED QA] Bug 10514 [Alternate] Add item link on acquisitions add item is too small This alternate patch for Bug 10514 converts the "Add" and "Clear" links to the standard "submit/cancel" format inside a fieldset. This gives them a little more visual weight to solve the problem in a differnt way. Based on the changes made by Liz Rea and Jonathan Druart. Same test plan: create a basket add a record to it scroll down - the link to add item and cancel should both be more prominent now. Click "Add item" - it should add an item. Signed-off-by: Liz Rea <liz@catalyst.net.nz> I still feel weird about the button, but as two people have said they'd rather have the button, I'm alright with it I guess. Really what I want is people to notice it's there and click it at the appropriate time. I hope this will help that issue. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Leaves the translation problems, but that needs more work and is out of the scope of this bug. Tested Add and Update functionality works correctly.
Created attachment 19586 [details] screenshot - display using alternate patch
I have attached 2 screenshots to compare the results of both patches. I personally like the second a bit better, because it fits how we do things in other places. There was also a suggestion to add some additional text to the form on IRC: (23:28:47) rangi: id like some text (23:28:51) rangi: right below Item (23:29:15) rangi: (Fill in the following form and click add, to add 1 item to your order, do this as many times as needed)
Pushed to master. Thanks, everybody!
This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks everyone involved!
Pushed to 3.10.x, will be in 3.10.10
Pushed to 3.8.x, will be in 3.8.17