There are some English strings embedded in additem.js which cannot be translated. Others are wrapped in the "_()" function but this doesn't help--JS files are not processed by the translation script.
Created attachment 19796 [details] [review] Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item."
Created attachment 19818 [details] [review] Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 19829 [details] [review] [PASSED QA] Bug 10576 - Untranslatable strings in additem.js There are a couple of untranslatable strings in additem.js. This patch moves the strings out of the script and into the include file which has been created for this purpose. To test, apply the patch and test the process for adding an item to an existing or new basket (with AcqCreateItem set to "when placing an order." The add item form should be correctly labeled "Add item." After adding an item, click to edit it again. The form should now be labeled "Update item." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely and passes all tests. Made sure strings can be translated testing with German templates.
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen!
Pushed to 3.10.x, will be in 3.10.11