Bug 10531 - Add basket name, PO number and order date on receive
Summary: Add basket name, PO number and order date on receive
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement with 1 vote (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
: 8120 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-07-03 05:35 UTC by Amit Gupta
Modified: 2022-05-13 15:20 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Basket name and PO number on receipt screen (4.98 KB, patch)
2013-08-13 05:19 UTC, Amit Gupta
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10531 - Basket name and PO number on receipt screen (5.20 KB, patch)
2013-08-26 19:17 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Gupta 2013-07-03 05:35:30 UTC
To list the basket name or PO number on the receipt screen to identify the lot that you are receiving
Comment 1 Amit Gupta 2013-08-13 05:19:04 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-08-26 19:17:42 UTC
Created attachment 20636 [details] [review]
[SIGNED-OFF] Bug 10531 - Basket name and PO number on receipt screen

To list the basket name or PO number on the receipt screen to
identify the lot that you are receiving

Test Plan:
1) Create an basket
2) Create an order
3) Click on Receive shipment button enter vendor invoice no and
shipment date click on Next button.
4) Basket name and Purchase order number will display both in pending
and already receive screen.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Two minor edits on signoff: Changed "basketname" to "basket name," and
converted tabs to spaces on added lines.
Comment 3 Jonathan Druart 2013-08-27 09:39:43 UTC
QA comment:

1/ This patch breaks sorts on the already received table.
2/ The sort on the basket name column does not work (on the Pending orders table).
3/ Prefer to list the fields you want for the aqbasket table:
+        SELECT aqorders.*, biblio.*, aqbasket.*
+        SELECT aqorders.*, biblio.*, aqbasket.purchase_order, aqbasket.basketname

Marked as Failed QA.
Comment 4 Jonathan Druart 2013-08-27 09:55:29 UTC
In fact, there is a js error on this page: 
  ReferenceError: YAHOO is not defined

Already exists on master.
Comment 5 Jonathan Druart 2013-08-27 10:03:44 UTC
(In reply to Jonathan Druart from comment #4)
> In fact, there is a js error on this page: 
>   ReferenceError: YAHOO is not defined
> 
> Already exists on master.

error caused by the following line:
  <script type="text/javascript" src="[% yuipath %]/json/json-min.js"></script>
It could be removed (see bug 10786).

But this patch adds another one:
  TypeError: a.aoColumns[c] is undefined
which does not exist on master.
Comment 6 Amit Gupta 2013-10-18 15:35:19 UTC
Hi Jonathan,

I cannot find any error in this patch. Can you please explain me in detail. 
Mean while i am changing the status of the patch.
Comment 7 Jonathan Druart 2013-10-21 12:40:31 UTC
(In reply to Amit from comment #6)
> Hi Jonathan,
> 
> I cannot find any error in this patch. Can you please explain me in detail. 
> Mean while i am changing the status of the patch.

Amit,
To reproduce: Open firebug, Go on acqui/parcel.pl?invoiceid=X, you will see a JS error: "TypeError: a.aoColumns[c] is undefined".
When you add a new column in a table managed by DataTables, you should adapt the aoColumns values.

Back to assigned.
Comment 8 Katrin Fischer 2019-04-28 18:22:37 UTC
*** Bug 8120 has been marked as a duplicate of this bug. ***
Comment 9 Katrin Fischer 2019-04-28 18:23:34 UTC
Merging with the duplicate bug 8120 and resetting to NEW.