Bug 10699 - DeleteBranchTransferLimits in C4/Circulation.pm needs return value
Summary: DeleteBranchTransferLimits in C4/Circulation.pm needs return value
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on: 10692
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-08 09:25 UTC by kenza
Modified: 2014-12-07 20:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value (2.38 KB, patch)
2013-08-08 09:45 UTC, kenza
Details | Diff | Splinter Review
Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value (2.43 KB, patch)
2013-08-08 22:37 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value (2.54 KB, patch)
2013-08-25 17:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description kenza 2013-08-08 09:25:36 UTC

    
Comment 1 kenza 2013-08-08 09:45:25 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-08-08 22:37:17 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-08-25 17:55:40 UTC
Created attachment 20597 [details] [review]
[PASSED QA] Bug 10699:DeleteBranchTransferLimits in C4/Circulation.pm needs return value

This patch adds return values to DeleteBranchTransferLimits:
1 if a Transfer Limit is deleted
undef if no parameters is given
0E0 if a wrong parameter is given

More, it fixes and adds some tests in t/db_dependent/Circulation_transfers.t

To test :
prove t/db_dependent/Circulation_transfers.t
t/db_dependent/Circulation_transfers.t .. ok
All tests successful.
Files=1, Tests=14, 19 wallclock secs ( 0.02 usr  0.01 sys +  0.39 cusr  0.02 csys =  0.44 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with patch for bug 10692 applied.
Comment 4 Galen Charlton 2013-08-28 15:35:47 UTC
Pushed to master, along with a follow-up that improves the function's POD and fixes the parameter checking.  Thanks, Kenza!
Comment 5 Tomás Cohen Arazi 2013-09-13 18:06:13 UTC
This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Kenza!