10692 – UT: Routines about transfers in C4::Circulation.pm need unit tests

Bug 10692 - UT: Routines about transfers in C4::Circulation.pm need unit tests

Summary: UT: Routines about transfers in C4::Circulation.pm need unit tests

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Test Suite (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low normal
Assignee:	kenza
QA Contact:	Testopia

URL:
Keywords:

Depends on:	10681
Blocks:	10693 10698 10699
	Show dependency tree / graph

Reported:	2013-08-07 13:47 UTC by kenza
Modified:	2014-12-07 20:02 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests (7.15 KB, patch) 2013-08-07 14:08 UTC, kenza	Details \| Diff \| Splinter Review
Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests (7.21 KB, patch) 2013-08-08 05:41 UTC, Chris Cormack	Details \| Diff \| Splinter Review
[PASSED QA] Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests (7.27 KB, patch) 2013-08-25 17:50 UTC, Katrin Fischer	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description kenza 2013-08-07 13:47:44 UTC

"CreateBranchTransferLimit", "DeleteBranchTransferLimits", "DeleteTransfer", "GetTransfers", "GetTransfersFromTo" need unit tests.

Comment 1 kenza 2013-08-07 14:08:53 UTC Comment hidden (obsolete)

Created attachment 20144 [details] [review]
Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests

The tests are wrap in a transaction.

NOTE: Currently, some tests should pass but don't because of incoherences in the code.
These tests are in comments and preceded by FIXME.

To test:
prove t/db_dependent/Circulation_transfers.t
t/db_dependent/Circulation_transfers.t .. ok
All tests successful.
Files=1, Tests=12, 18 wallclock secs ( 0.02 usr  0.01 sys +  0.37 cusr  0.06 csys =  0.46 CPU)
Result: PASS

Comment 2 Chris Cormack 2013-08-08 05:41:59 UTC Comment hidden (obsolete)

Created attachment 20158 [details] [review]
Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests

The tests are wrap in a transaction.

NOTE: Currently, some tests should pass but don't because of incoherences in the code.
These tests are in comments and preceded by FIXME.

To test:
prove t/db_dependent/Circulation_transfers.t
t/db_dependent/Circulation_transfers.t .. ok
All tests successful.
Files=1, Tests=12, 18 wallclock secs ( 0.02 usr  0.01 sys +  0.37 cusr  0.06 csys =  0.46 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Comment 3 Katrin Fischer 2013-08-25 17:50:35 UTC

Created attachment 20596 [details] [review]
[PASSED QA] Bug 10692: Routines about transfers in C4::Circulation.pm need unit tests

The tests are wrap in a transaction.

NOTE: Currently, some tests should pass but don't because of incoherences in the code.
These tests are in comments and preceded by FIXME.

To test:
prove t/db_dependent/Circulation_transfers.t
t/db_dependent/Circulation_transfers.t .. ok
All tests successful.
Files=1, Tests=12, 18 wallclock secs ( 0.02 usr  0.01 sys +  0.37 cusr  0.06 csys =  0.46 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Comment 4 Galen Charlton 2013-08-28 15:13:23 UTC

Pushed to master.  Thanks, Kenza!

Comment 5 Tomás Cohen Arazi (tcohen) 2013-09-13 18:05:00 UTC

This patch has been pushed to 3.12.x, will be in 3.12.5.

Thanks Kenza!