My patch for Bug 10083 may have made the in-transit strings translatable, but it messed up the template variable names so that the details don't show.
Created attachment 20191 [details] [review] Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013"
Created attachment 20194 [details] [review] Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no errors. Before patch incorrect information: "In transit from to since" after patch correct information.
Created attachment 20434 [details] [review] [PASSED QA] Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no errors. Before patch incorrect information: "In transit from to since" after patch correct information. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works perfectly and passes all tests.
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen!
Does not apply cleanly to 3.10.x, please submit one formatted for 3.10.x