This patch replaces carriage return with <br /> in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - return an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl <directory> Without the patch, the script generates a html file without <br /> tags. If you run printoverdues.sh <directory>, the text in the resulting pdf file is all on one line With the patch, the script generates a html file with <br/> tags and pdf file created by printoverdues.sh is well formatted.
Created attachment 20330 [details] [review] Bug 10727 : Replace carriage return with <br /> when printing hold notices This patch replaces carriage return with <br /> in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl <directory> Without the patch, the script generates a html file without <br /> tags. If you run printoverdues.sh <directory>, the text in the resulting pdf file is all on one line With the patch, the script generates a html file with <br/> tags and pdf file created by printoverdues.sh is well formatted.
In such cases, it is slightly better to say (within the loop): local $_ = $message->{'content'}; S/// ... That saves two var copies. I will make that change when signing off.
Created attachment 20755 [details] [review] Bug 10727 : Replace carriage return with <br /> when printing hold notices This patch replaces carriage return with <br /> in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl <directory> Without the patch, the script generates a html file without <br /> tags. If you run printoverdues.sh <directory>, the text in the resulting pdf file is all on one line With the patch, the script generates a html file with <br/> tags and pdf file created by printoverdues.sh is well formatted. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Please disregard my comment, wasn't too intelligent.
Created attachment 20830 [details] [review] Bug 10727 : Replace carriage return with <br /> when printing hold notices This patch replaces carriage return with <br /> in the content of hold notices for printing. This is necessary to convert html file into well formatted pdf file. Test plan : - checkin an item reserved by a borrower that has not activated email notification - verify in message_queue table that you've got a new HOLD_PRINT notice with status 'pending' - run gather_print_notices.pl <directory> Without the patch, the script generates a html file without <br /> tags. If you run printoverdues.sh <directory>, the text in the resulting pdf file is all on one line With the patch, the script generates a html file with <br/> tags and pdf file created by printoverdues.sh is well formatted. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Sophie!
This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Sophie!
Pushed to 3.10.x, will be in 3.10.12
Created attachment 28502 [details] [review] [SIGNED-OFF] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors. Exact reversion of 10727. Just thinking, again you will get all text in one line [1] [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727#c0
Comment on attachment 28502 [details] [review] [SIGNED-OFF] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" Sorry, wrong bug