Bug 12300 - Revert BZ10727 - Remove duplicate <br /> in printed hold notices
Summary: Revert BZ10727 - Remove duplicate <br /> in printed hold notices
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Sophie MEYNIEUX
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-21 09:28 UTC by Sophie MEYNIEUX
Modified: 2017-06-14 22:08 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" (967 bytes, patch)
2014-05-21 09:42 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices" (1.18 KB, patch)
2014-05-27 21:26 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2014-05-21 09:28:13 UTC
To be consistent with overdue notices, HOLD_PRINT model should be formated in html and <br /> written directly in the letter.
In this case, replacing carriage return with <br /> duplicates new lines in the final printed file.
Comment 1 Sophie MEYNIEUX 2014-05-21 09:42:23 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-05-27 21:26:35 UTC
Created attachment 28503 [details] [review]
[SIGNED-OFF] Bug 12300 : Revert Bug 10727: Cancel replacing carriage return with <br /> when printing hold notices"

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No errors.

Exact reversion of 10727.
Just thinking, again you will get all text in one line [1]

[1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727#c0
Comment 3 Marcel de Rooy 2014-05-28 12:19:33 UTC
> Exact reversion of 10727.
> Just thinking, again you will get all text in one line [1]

Sounds like we are reverting a partial solution to get back a partial problem :)

BTW: Should gather_print_notices not look at the content of each message before deciding to do a replace? The message could be plain text or html depending on the letter definition.

Can we use this opportunity to come up with a more elegant solution? Perhaps you could ask Jonathan to assist here since this comes close to his work on message transport types..

Moving status to Failed QA.
Comment 4 Sophie MEYNIEUX 2016-08-24 13:46:52 UTC
Since Bug 11603 as been pushed, HOLD_PRINT is not used any more, there is no need of this patch