To reproduce: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. It won't save and there is no error message or explanation given.
*** Bug 13086 has been marked as a duplicate of this bug. ***
Still valid on 3.19.00.012 Seems to be by design See: suggestion/suggestion.pl around line 132 ###FIXME:Search here if suggestion already exists. my $suggestions_loop = SearchSuggestion( $suggestion_only ); if (@$suggestions_loop>=1){ #some suggestion are answering the request Donot Add } else { ## Adding some informations related to suggestion &NewSuggestion($suggestion_only); }
Created attachment 37967 [details] [review] Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface.
QA: I already used the message trick in some other bugs: bug 10363, bug 10855, bug 11023
Created attachment 37991 [details] [review] Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Love the simplicity and ability to expand. :)
This works really nicely, but there are 2 small problems: 1) I notice is that the link is not visible as a link - the font is all red and hiding away that you can click on the text in the parenthesis. - wondering, do we have another style we could use here? 2) Enter the first as "Test" then another as "Test " - you can save it without any complaint. Now create another "Test" - the error message is appearing twice? 3) The other problem... is that this also appears in the OPAC where the user is left with questionmarks why his/her suggestion didn't save. :( Not a blocker, but would be great to see it fixed!
Created attachment 38159 [details] [review] Bug 10752: Remove the specific css for links in an error dialog Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489 Date: Tue Mar 20 15:20:25 2012 +0100 Bug 6209 [Revised] Standardize on one plugin for client-side form validation It did not find how it could be useful.
Created attachment 38160 [details] [review] Bug 10752: Alert if the suggestion has not been added - OPAC Same as previous patches for the OPAC. Test plan is the same.
(In reply to Katrin Fischer from comment #6) > This works really nicely, but there are 2 small problems: > > 1) I notice is that the link is not visible as a link - the font is all red > and hiding away that you can click on the text in the parenthesis. - > wondering, do we have another style we could use here? Ok fixed, I have deleted few css lines. I think they were not used. > 2) Enter the first as "Test" then another as "Test " - you can save it > without any complaint. Now create another "Test" - the error message is > appearing twice? Yes, it's caused by the way the search is done. To know if a suggestion exists, a LIKE "%$term%" is done, so if one exists with "Test" in the same, it won't be inserted. I prefer to show all results rather than choose 1 of them. > 3) The other problem... is that this also appears in the OPAC where the user > is left with questionmarks why his/her suggestion didn't save. :( Not a > blocker, but would be great to see it fixed! Done in the last patch.
Created attachment 38204 [details] [review] [Signed-off] Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Love the simplicity and ability to expand. :) Tested with all pateches applied. Wors as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38205 [details] [review] [Signed-off] Bug 10752: Remove the specific css for links in an error dialog Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489 Date: Tue Mar 20 15:20:25 2012 +0100 Bug 6209 [Revised] Standardize on one plugin for client-side form validation It did not find how it could be useful. --- Tested with all pateches applied. Wors as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38206 [details] [review] [Signed-off] Bug 10752: Alert if the suggestion has not been added - OPAC Same as previous patches for the OPAC. Test plan is the same. Tested with all patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38213 [details] [review] [PASSED QA] Bug 10752: Alert the librarian if the suggestion has not been added Test plan: - Create a new suggestion, chose a short term as your title and copy it. - Leave all other fields of the suggestion form untouched. - Save your first suggestion. - Enter a second suggestion with the same title. Before this patch, the suggestion was not inserted without alert. With this patch, an alert is displayed on the interface. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Love the simplicity and ability to expand. :) Tested with all pateches applied. Wors as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38214 [details] [review] [PASSED QA] Bug 10752: Remove the specific css for links in an error dialog Comes from commit c28f7d7de5d1e1a8d5e0038b76fce74397c3c489 Date: Tue Mar 20 15:20:25 2012 +0100 Bug 6209 [Revised] Standardize on one plugin for client-side form validation It did not find how it could be useful. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38215 [details] [review] [PASSED QA] Bug 10752: Alert if the suggestion has not been added - OPAC Same as previous patches for the OPAC. Test plan is the same. Tested with all patches applied. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38216 [details] [review] Bug 14022: Follow-up - rephrase erorr messages a little Rephrased error messages a little and changed the link to look like it does on other pages, for example when looking at an order created from a suggestion. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #16) > Created attachment 38216 [details] [review] [review] > Bug 14022: Follow-up - rephrase erorr messages a little > > Rephrased error messages a little and changed the link to > look like it does on other pages, for example when looking > at an order created from a suggestion. > > Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Katrin, is the bug number on the patch subject wrong and this really belongs here? (it seems so, just over-checking)
No idea where i got the number from... can you please fix? The patch at least belongs here.
Patches pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.7