When editing a subscription the subscription length (second page) is reset to issues, even if the subscription was initially saved with a value in months or weeks. This is more of a problem as it sounds even, as a high value in 'issues' can bring created a lot of load on the server with a lot of database requests and causes vry slow response times.
Created attachment 38197 [details] [review] Bug 14022: Does not reset the subscription length on editing a subscription The subscription length is always set to the first/default value ('issues') when editing a subscription. Even if you selected another value on creating/editing it, the form will show you the first option. Test plan: 1/ Add/Edit a subscription, select a subscription length different of the first value (issues) 2/ Edit the subscription and confirm the value is kept Bonus: issues, week and months become translatable.
Created attachment 38202 [details] [review] [Signed-off] Bug 14022: Does not reset the subscription length on editing a subscription The subscription length is always set to the first/default value ('issues') when editing a subscription. Even if you selected another value on creating/editing it, the form will show you the first option. Test plan: 1/ Add/Edit a subscription, select a subscription length different of the first value (issues) 2/ Edit the subscription and confirm the value is kept Bonus: issues, week and months become translatable. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 38209 [details] [review] [PASSED QA] Bug 14022: Does not reset the subscription length on editing a subscription The subscription length is always set to the first/default value ('issues') when editing a subscription. Even if you selected another value on creating/editing it, the form will show you the first option. Test plan: 1/ Add/Edit a subscription, select a subscription length different of the first value (issues) 2/ Edit the subscription and confirm the value is kept Bonus: issues, week and months become translatable. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.7