Created attachment 20734 [details] [review] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority).
Created attachment 20764 [details] [review] Bug 10807: FIX if zebra is down, total is undef The search_history.total column cannot be undef. This patch adds a default value for the total value.
Created attachment 20951 [details] [review] Bug 10807: Add an authority search history for the OPAC
Created attachment 20952 [details] [review] Bug 10807: FIX if zebra is down, total is undef
Created attachment 20988 [details] [review] [SIGNED-OFF] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 20989 [details] [review] [SIGNED-OFF] Bug 10807: FIX if zebra is down, total is undef The search_history.total column cannot be undef. This patch adds a default value for the total value. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This change doesn't negatively affect search history as far as I can tell but I also can't reproduce the bug it is meant to fix, so take this signoff with a grain of salt.
Created attachment 20990 [details] [review] Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off.
Created attachment 21070 [details] [review] Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Owen, Thank you for the followup, I let you change the status to "signed off" if it is good for you.
Hum(In reply to Jonathan Druart from comment #9) > Owen, > Thank you for the followup, I let you change the status to "signed off" if > it is good for you. I didn't change it on purpose :) So... since 2 first patchs has been signed off, I suppose the status is correct.
Hi Jonathan, could you take a look at the license and check if you want to update to GPL3? FAIL C4/Search/History.pm OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 261) OK valid OK critic Continueing testing...
Hi Jonathan, I wonder if PurgeSearchHistory should be moved into the new module, what do you think? It was introduced by bug 10361.
Some more notes: 1) The subs in Search:History.pm don't seem to follow our usual naming conventions. I am a bit unsure about this. 2) Shouldn't Search_SearchHistory.t be Search_History.t? 3) Search_SearchHistory.t also fails for me: [~/kohaclone (52-10807-authoritysearchhistory)]> prove t/db_dependent/Search_SearchHistory.t t/db_dependent/Search_SearchHistory.t .. 1/6 # Failed test 'use C4::Search;' # at t/db_dependent/Search_SearchHistory.t line 24. # Tried to use 'C4::Search'. # Error: "AddSearchHistory" is not exported by the C4::Search module # Can't continue after import errors at (eval 26) line 2 # BEGIN failed--compilation aborted at (eval 26) line 2. t/db_dependent/Search_SearchHistory.t .. 2/6 Undefined subroutine &main::AddSearchHistory called at t/db_dependent/Search_SearchHistory.t line 39. # Looks like you planned 6 tests but ran 2. # Looks like you failed 1 test of 2 run. # Looks like your test exited with 255 just after 2. t/db_dependent/Search_SearchHistory.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/6 subtests Failing for 3), but please check with Galen about 1) if possible and take a look at the other comments. Thx!
(In reply to Katrin Fischer from comment #11) > Hi Jonathan, Katrin, > could you take a look at the license and check if you want to update to GPL3? > FAIL C4/Search/History.pm > OK pod > FAIL forbidden patterns > forbidden pattern: Koha is now under the GPLv3 license (line 261) Will be fixed in a followup. (In reply to Katrin Fischer from comment #12) > I wonder if PurgeSearchHistory should be moved into the new module, what do > you think? It was introduced by bug 10361. I open a new report for that : bug 10933. (In reply to Katrin Fischer from comment #13) > Some more notes: > > 1) The subs in Search:History.pm don't seem to follow our usual naming > conventions. I am a bit unsure about this. I wasn't aware about this rule. I just see it's in the coding guidelines but I am wondering if it is currently the case. Looking at the Koha namespace a lot of modules don't use the CamelCase notation. > 2) Shouldn't Search_SearchHistory.t be Search_History.t? Not from this patch. Bug 10933 will delete this file. > 3) Search_SearchHistory.t also fails for me: I will fix that!
Created attachment 21362 [details] [review] Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 21363 [details] [review] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment on attachment 20988 [details] [review] [SIGNED-OFF] Bug 10807: Add an authority search history for the OPAC Review of attachment 20988 [details] [review]: ----------------------------------------------------------------- For follow-up. ::: C4/Search/History.pm @@ +1,2 @@ > +package C4::Search::History; > + Why not Koha::Search::History since it's a new module? ::: installer/data/mysql/kohastructure.sql @@ +1879,4 @@ > `sessionid` varchar(32) NOT NULL, -- a system generated session id > `query_desc` varchar(255) NOT NULL, -- the search that was performed > `query_cgi` text NOT NULL, -- the string to append to the search url to rerun the search > + `type` varchar(255) NOT NULL DEFAULT 'biblio', -- search type, must be 'biblio' or 'authority' varchar(255) is too wide for this if the only values are either 'biblio' or 'authority'.
(In reply to Jonathan Druart from comment #14) > > 1) The subs in Search:History.pm don't seem to follow our usual naming > > conventions. I am a bit unsure about this. > > I wasn't aware about this rule. I just see it's in the coding guidelines but > I am wondering if it is currently the case. Looking at the Koha namespace a > lot of modules don't use the CamelCase notation. Yeah, we haven't been consistent. I have no strong feelings one way or the other.
(In reply to Galen Charlton from comment #18) > (In reply to Jonathan Druart from comment #14) > > > 1) The subs in Search:History.pm don't seem to follow our usual naming > > > conventions. I am a bit unsure about this. > > > > I wasn't aware about this rule. I just see it's in the coding guidelines but > > I am wondering if it is currently the case. Looking at the Koha namespace a > > lot of modules don't use the CamelCase notation. > > Yeah, we haven't been consistent. I have no strong feelings one way or the > other. Me either, except I think that for a module that isn't OO, get is a bad name for a subroutine. If it were $history->get() I'd be ok with that. But having to fully qualify it Search::History::get() to make it meaningful I think is a bit clumsy.
(In reply to Chris Cormack from comment #19) > Me either, except I think that for a module that isn't OO, get is a bad name > for a subroutine. > > If it were $history->get() I'd be ok with that. But having to fully qualify > it Search::History::get() to make it meaningful I think is a bit clumsy. Indeed, although a fully-qualified Search::History::get() might be better than optionally exporting a GetSearchHistory(). But I think we're more or less on the same page -- best of all would be turning it into a class, and I think that could be done with only a small effort.
(In reply to Galen Charlton from comment #20) > (In reply to Chris Cormack from comment #19) > > Me either, except I think that for a module that isn't OO, get is a bad name > > for a subroutine. > > > > If it were $history->get() I'd be ok with that. But having to fully qualify > > it Search::History::get() to make it meaningful I think is a bit clumsy. > > Indeed, although a fully-qualified Search::History::get() might be better > than optionally exporting a GetSearchHistory(). > > But I think we're more or less on the same page -- best of all would be > turning it into a class, and I think that could be done with only a small > effort. Hello Chris and Galen, I created the module in the C4 namespace precisely because it is not a OO module. There are some doubt (at least for me) about how to create a new module into Koha: Dbix will arrive shortly (or not), Moo, Class::Accessor, etc. The last time I thought I created a correct module (bug 10363), the patch has been ejected in the discussion status. With this patch, I simply tried to group search history code into a module in order to re-use it somewhere else (bug 10862).
Created attachment 21403 [details] [review] Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values.
(In reply to Jonathan Druart from comment #21) > I created the module in the C4 namespace precisely because it is not a OO > module. I don't recall there be any requirement that the Koha names *only* be for OO-modules. New modules should preferentially be OO, but there is a place in Koha for modules that are simply collections of utility code. In this case, Koha::Search::History can be readily made OO, IMO. > There are some doubt (at least for me) about how to create a new module into > Koha: Dbix will arrive shortly (or not), Moo, Class::Accessor, etc. I suggest running with Class::Accessor -- there are plenty of examples in the Koha namespace already.
(In reply to Galen Charlton from comment #23) > I suggest running with Class::Accessor -- there are plenty of examples in > the Koha namespace already. What I did in bug 10862.
(In reply to Galen Charlton from comment #23) > (In reply to Jonathan Druart from comment #21) > > I created the module in the C4 namespace precisely because it is not a OO > > module. > > I don't recall there be any requirement that the Koha names *only* be for > OO-modules. New modules should preferentially be OO, but there is a place > in Koha for modules that are simply collections of utility code. Galen, It is in the coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-oriented_code_and_the_Koha::_namespace To me this module is not perfect (by far). So I had a preference for submitting the module as it into the C4 namespace. > In this case, Koha::Search::History can be readily made OO, IMO. I will try to move the existing module to the Koha namespace. But I prefer to do it after these patches (and patches from bug 10862) will be pushed. Hope that make sense.
Created attachment 22560 [details] [review] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 22561 [details] [review] Bug 10807: FIX if zebra is down, total is undef The search_history.total column cannot be undef. This patch adds a default value for the total value. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This change doesn't negatively affect search history as far as I can tell but I also can't reproduce the bug it is meant to fix, so take this signoff with a grain of salt.
Created attachment 22562 [details] [review] Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 22563 [details] [review] Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 22564 [details] [review] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 22565 [details] [review] Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values.
Created attachment 23676 [details] [review] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 23677 [details] [review] Bug 10807: FIX if zebra is down, total is undef The search_history.total column cannot be undef. This patch adds a default value for the total value. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This change doesn't negatively affect search history as far as I can tell but I also can't reproduce the bug it is meant to fix, so take this signoff with a grain of salt.
Created attachment 23678 [details] [review] Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 23679 [details] [review] Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 23680 [details] [review] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 23681 [details] [review] Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values.
Created attachment 23682 [details] [review] Bug 10807: Add an authority search history for the OPAC - bootstrap Patch for the bootstrap theme Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I fixed a conflict in the first patch and add a new patch for the bootstrap theme.
Created attachment 23712 [details] [review] Bug 10807: FIX conflicts with bug 10380 Bug 10380 changes the prototype of the output_pref routine. Now it should take a hashref in parameters. Without this patch, an error occurred if the user was not looged in and try to access to his search history (Template process failed: undef error - The 'day' parameter ("2013") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback")
Hi Jonathan, I am sorry, but there are too many conflicts outside of updatedatabase. Could you please rebase?
Created attachment 24221 [details] [review] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 24222 [details] [review] Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24223 [details] [review] Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24224 [details] [review] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24225 [details] [review] Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values.
Created attachment 24226 [details] [review] Bug 10807: Add an authority search history for the OPAC - bootstrap Patch for the bootstrap theme Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Last patches fix big conflict with bug 10952.
Starting to test...
Sorry, I forgot a bit about this :( Resettig the QA contact, so if someone gets to this before I do - feel free to take over!
Back on this.
Comment on attachment 24221 [details] [review] Bug 10807: Add an authority search history for the OPAC Review of attachment 24221 [details] [review]: ----------------------------------------------------------------- ::: C4/Auth.pm @@ +251,5 @@ > > # If at least one search has already been performed > if ($sth->fetchrow_array > 0) { > + # We show the link in opac > + $template->param( EnableOpacSearchHistory => 1 ); I am not sure renaming the variable was necessary. Now it shows up in the templates like the system preference, although there is another condition that it takes into account. Also tempting to replace it with the TT plugin accidentally.
Created attachment 27372 [details] [review] [PASSED QA] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All patches together pass QA script and tests. Also, new tests in t/db_dependent/ pass. Tested in all 4 OPAC themes, being logged in and anonymous. Anonymous search history will be appended to personal search history after logging in. Also verified that cleanup_database still purges search history, now also including the authority searchs.
Created attachment 27373 [details] [review] [PASSED QA] Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 27374 [details] [review] [PASSED QA] Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 27375 [details] [review] [PASSED QA] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 27376 [details] [review] [PASSED QA] Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 27377 [details] [review] [PASSED QA] Bug 10807: Add an authority search history for the OPAC - bootstrap Patch for the bootstrap theme Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 27378 [details] [review] Bug 10807: Follow-up: Change wording of tabs Changed the tabs from Catalog and Authority to Catalog searches and Authority searches to be a bit more specific.
Pushed to master. Thanks, Jonathan!