Bug 10862 - Add an search history for the staff interface
Summary: Add an search history for the staff interface
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low new feature (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 10807
Blocks: 11430
  Show dependency treegraph
 
Reported: 2013-09-10 11:58 UTC by Jonathan Druart
Modified: 2015-06-04 23:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10862: Add an search history for the intranet interface (19.73 KB, patch)
2013-09-10 13:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10862: Followup: fix a couple of issues (5.70 KB, patch)
2013-09-11 08:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10862: FIX if the query returns 1 result, it does not appears in the history (3.64 KB, patch)
2013-09-12 09:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10862: Add an search history for the intranet interface (19.83 KB, patch)
2013-09-12 17:05 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10862: Followup: fix a couple of issues (5.79 KB, patch)
2013-09-12 17:05 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10862: FIX if the query returns 1 result, it does not appears in the history (3.74 KB, patch)
2013-09-12 17:06 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10862: Add an search history for the intranet interface (19.82 KB, patch)
2013-10-20 19:38 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10862: Followup: fix a couple of issues (5.81 KB, patch)
2013-10-20 19:39 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10862: FIX if the query returns 1 result, it does not appears in the history (3.73 KB, patch)
2013-10-20 19:40 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-09-10 11:58:50 UTC
Like OPAC, the search history will be available for the staff interface.
Comment 1 Jonathan Druart 2013-09-10 13:07:33 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-09-10 19:35:58 UTC
- Seems to be missing History.pm?
- Database update message refers to "MT12541" rather than Bug 10862.
- Typically new features like this are not enabled by default.
- Preference description says "...patron search history in the OPAC." It should
  say "staff client."
- catalogue/search-history.tt should use new datatables include file (Bug 10649)
- The search history page title and breadcrumbs say "History search" where 
  it should say "Search history"
- I suggest that we use the term "catalog" instead of "biblio." "biblio" isn't really a word in English, although we use it Koha some places. I think naming the tabs "Catalog" and "Authority" would be clear:

"Your catalog search history is empty."
"Delete your current catalog search history"
"Delete your previous catalog search history"
Comment 3 Jonathan Druart 2013-09-11 08:39:11 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-09-11 08:40:43 UTC
(In reply to Owen Leonard from comment #2)
> - Seems to be missing History.pm?
> - Database update message refers to "MT12541" rather than Bug 10862.
> - Typically new features like this are not enabled by default.
> - Preference description says "...patron search history in the OPAC." It
> should
>   say "staff client."
> - catalogue/search-history.tt should use new datatables include file (Bug
> 10649)
> - The search history page title and breadcrumbs say "History search" where 
>   it should say "Search history"
> - I suggest that we use the term "catalog" instead of "biblio." "biblio"
> isn't really a word in English, although we use it Koha some places. I think
> naming the tabs "Catalog" and "Authority" would be clear:
> 
> "Your catalog search history is empty."
> "Delete your current catalog search history"
> "Delete your previous catalog search history"

Owen,
Thanks for testing!
The History.pm module is added by the bug 10807.
All others requests are fixed in the followup.
Comment 5 Owen Leonard 2013-09-11 12:57:06 UTC
(In reply to Jonathan Druart from comment #4)

> The History.pm module is added by the bug 10807.

Whoops, sorry--I missed the dependency! Now that I can test it for real I see a couple more things:

1) search-history.tt lacks [% INCLUDE 'doc-head-open.inc' %] at the top of the page
2) Not blocking, but strange: If my search returns one hit and I'm redirected to the detail page for that title the search doesn't appear in my history.
Comment 6 Jonathan Druart 2013-09-12 09:53:22 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2013-09-12 17:05:31 UTC Comment hidden (obsolete)
Comment 8 Owen Leonard 2013-09-12 17:05:44 UTC Comment hidden (obsolete)
Comment 9 Owen Leonard 2013-09-12 17:06:34 UTC Comment hidden (obsolete)
Comment 10 Chris Cormack 2013-10-20 19:38:24 UTC
Created attachment 22100 [details] [review]
Bug 10862: Add an search history for the intranet interface

Like OPAC, the search history is now available for intranet.

Test plan:
 1/ Switch on the 'EnableSearchHistory' syspref.
 3/ Launch some biblio and authority searches.
 4/ Go on your search history page (top right, under "Set library").
 5/ Check that all yours searches are displayed.
 6/ Click on some links and check that results are consistent.
 7/ Delete your biblio history searches.
 8/ Delete your authority searches history searches.
 9/ Launch some biblio and authority searches
10/ Play with the 4 delete links (current / previous and biblio /
authority).

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 11 Chris Cormack 2013-10-20 19:39:21 UTC
Created attachment 22101 [details] [review]
Bug 10862: Followup: fix a couple of issues

This followup fixes a couple of issues:
- disable the feature by default.
- use the datatables include file.
- fix the syspref description.
- replace "History search" with "Search history".
- replace biblio with catalog

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 12 Chris Cormack 2013-10-20 19:40:01 UTC
Created attachment 22102 [details] [review]
Bug 10862: FIX if the query returns 1 result, it does not appears in the history

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 13 Galen Charlton 2014-03-10 21:17:57 UTC
Setting to blocked until such time as bug 10807 passes QA.
Comment 14 Galen Charlton 2014-05-05 03:12:22 UTC
Pushed to master.  Thanks, Jonathan!