- Seems to be missing History.pm?
- Database update message refers to "MT12541" rather than Bug 10862.
- Typically new features like this are not enabled by default.
- Preference description says "...patron search history in the OPAC." It should
  say "staff client."
- catalogue/search-history.tt should use new datatables include file (Bug 10649)
- The search history page title and breadcrumbs say "History search" where 
  it should say "Search history"
- I suggest that we use the term "catalog" instead of "biblio." "biblio" isn't really a word in English, although we use it Koha some places. I think naming the tabs "Catalog" and "Authority" would be clear:

"Your catalog search history is empty."
"Delete your current catalog search history"
"Delete your previous catalog search history"

(In reply to Owen Leonard from comment #2)
> - Seems to be missing History.pm?
> - Database update message refers to "MT12541" rather than Bug 10862.
> - Typically new features like this are not enabled by default.
> - Preference description says "...patron search history in the OPAC." It
> should
>   say "staff client."
> - catalogue/search-history.tt should use new datatables include file (Bug
> 10649)
> - The search history page title and breadcrumbs say "History search" where 
>   it should say "Search history"
> - I suggest that we use the term "catalog" instead of "biblio." "biblio"
> isn't really a word in English, although we use it Koha some places. I think
> naming the tabs "Catalog" and "Authority" would be clear:
> 
> "Your catalog search history is empty."
> "Delete your current catalog search history"
> "Delete your previous catalog search history"

Owen,
Thanks for testing!
The History.pm module is added by the bug 10807.
All others requests are fixed in the followup.

(In reply to Jonathan Druart from comment #4)

> The History.pm module is added by the bug 10807.

Whoops, sorry--I missed the dependency! Now that I can test it for real I see a couple more things:

1) search-history.tt lacks [% INCLUDE 'doc-head-open.inc' %] at the top of the page
2) Not blocking, but strange: If my search returns one hit and I'm redirected to the detail page for that title the search doesn't appear in my history.

Created attachment 22100 [details] [review]
Bug 10862: Add an search history for the intranet interface

Like OPAC, the search history is now available for intranet.

Test plan:
 1/ Switch on the 'EnableSearchHistory' syspref.
 3/ Launch some biblio and authority searches.
 4/ Go on your search history page (top right, under "Set library").
 5/ Check that all yours searches are displayed.
 6/ Click on some links and check that results are consistent.
 7/ Delete your biblio history searches.
 8/ Delete your authority searches history searches.
 9/ Launch some biblio and authority searches
10/ Play with the 4 delete links (current / previous and biblio /
authority).

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Created attachment 22101 [details] [review]
Bug 10862: Followup: fix a couple of issues

This followup fixes a couple of issues:
- disable the feature by default.
- use the datatables include file.
- fix the syspref description.
- replace "History search" with "Search history".
- replace biblio with catalog

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Created attachment 22102 [details] [review]
Bug 10862: FIX if the query returns 1 result, it does not appears in the history

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Setting to blocked until such time as bug 10807 passes QA.

Pushed to master.  Thanks, Jonathan!