On line 208, xmlControlfield.js is hardcoded to look for MARC21 XML files: url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml", In order to fix Bug 10997 I will need this JS to use the value of the marcflavour syspref.
Created attachment 21848 [details] [review] Bug 11004 - Make xmlControlfield.js use the marcflavour syspref to look for XML files Currently, xmlControlfield.js is hard coded to look for XML files for MARC21: url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml", This patch makes this code use the value from the marcflavour syspref, as a preparation for making the NORMARC value builders use the XML technique employed by the MARC21 value builders for 006 and 008. To test: - Make sure you have a MARC21 installation - Set marcflavour = NORMARC - Go to Cataloguing and start a new record with the default framework - Open the value builders for 006 and 008 and observe that they still work, showing the coded values for MARC21 - Apply this patch - Check the value builders for 006 and 008 and observe that you get a truncated view with an empty "Select a type of material" dropdown - Use e.g. the Net console in Firebug to observe requests to http://localhost/intranet-tmpl/prog/en/data/normarc_field_008.xml that result in a 404 status - Set marcflavour = MARC21 - Observe that the value builders for 006 and 008 are now fully working - 006 and 008 should be the only value builders affected by this change, since they are the only ones using xmlControlfield.js, but please also verify that other value builders are still working as expected
Maybe we could use the xml files for unimarc latter. I did not realized before that value builders were not build the same way in different marc flavor... M. Saby
Patch applied cleanly, go forth and signoff
Created attachment 23796 [details] [review] Bug 11004 - Make xmlControlfield.js use the marcflavour syspref to look for XML files Currently, xmlControlfield.js is hard coded to look for XML files for MARC21: url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml", This patch makes this code use the value from the marcflavour syspref, as a preparation for making the NORMARC value builders use the XML technique employed by the MARC21 value builders for 006 and 008. To test: - Make sure you have a MARC21 installation - Set marcflavour = NORMARC - Go to Cataloguing and start a new record with the default framework - Open the value builders for 006 and 008 and observe that they still work, showing the coded values for MARC21 - Apply this patch - Check the value builders for 006 and 008 and observe that you get a truncated view with an empty "Select a type of material" dropdown - Use e.g. the Net console in Firebug to observe requests to http://localhost/intranet-tmpl/prog/en/data/normarc_field_008.xml that result in a 404 status - Set marcflavour = MARC21 - Observe that the value builders for 006 and 008 are now fully working - 006 and 008 should be the only value builders affected by this change, since they are the only ones using xmlControlfield.js, but please also verify that other value builders are still working as expected Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
I am not sure to understand the patch: if marcflavour is NORMARC, normally 006 and 008 should not be linked to a plugin. Since it works as described and I have confidence in Magnus, I mark it as Passed QA.
Created attachment 23806 [details] [review] Bug 11004 - Make xmlControlfield.js use the marcflavour syspref to look for XML files Currently, xmlControlfield.js is hard coded to look for XML files for MARC21: url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml", This patch makes this code use the value from the marcflavour syspref, as a preparation for making the NORMARC value builders use the XML technique employed by the MARC21 value builders for 006 and 008. To test: - Make sure you have a MARC21 installation - Set marcflavour = NORMARC - Go to Cataloguing and start a new record with the default framework - Open the value builders for 006 and 008 and observe that they still work, showing the coded values for MARC21 - Apply this patch - Check the value builders for 006 and 008 and observe that you get a truncated view with an empty "Select a type of material" dropdown - Use e.g. the Net console in Firebug to observe requests to http://localhost/intranet-tmpl/prog/en/data/normarc_field_008.xml that result in a 404 status - Set marcflavour = MARC21 - Observe that the value builders for 006 and 008 are now fully working - 006 and 008 should be the only value builders affected by this change, since they are the only ones using xmlControlfield.js, but please also verify that other value builders are still working as expected Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Magnus!
Patch pushed to 3.14.x, will be in 3.14.2.