In Schemaspy, column cancelledby is reported as "not used? always NULL". "grep -r cancelledby *" give this result, so I suppose it is true : blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql: `cancelledby` varchar(10) default NULL, -- not used? always NULL blib/INTRANET_CGI_DIR/installer/data/Pg/kohastructure.sql:cancelledby varchar(10) default NULL, installer/data/mysql/kohastructure.sql: `cancelledby` varchar(10) default NULL, -- not used? always NULL installer/data/Pg/kohastructure.sql:cancelledby varchar(10) default NULL, t/db_dependent/Acquisition.t: cancelledby I propose the deletion of this column. M. Saby
Created attachment 29821 [details] [review] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green.
Created attachment 29823 [details] [review] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green.
(In reply to Jonathan Druart from comment #2) > 3/ prove t/db_dependent/Acquisition.t should return green. Does that test return green for you in master? It doesn't for me.
(In reply to Owen Leonard from comment #3) > (In reply to Jonathan Druart from comment #2) > > > 3/ prove t/db_dependent/Acquisition.t should return green. > > Does that test return green for you in master? It doesn't for me. Yes, what is the error you get?
Created attachment 30958 [details] [review] [SIGNED-OFF] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Created attachment 31038 [details] [review] [PASSED QA] Bug 11007: Drop column aqorders.cancelledby It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep cancelledby should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I couldn't find any trace of this column being used. Passes tests and QA script, updates all necessary files.
Patch pushed to master. Thanks Jonathan!