Bug 11075 - Clicking 'select all' link in export tab in checkout page clears renew checkboxes
Summary: Clicking 'select all' link in export tab in checkout page clears renew checkb...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-17 16:56 UTC by Galen Charlton
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11075 - 'select all' export clears renew checkboxes (1.51 KB, patch)
2013-11-21 17:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11075 - 'select all' export clears renew checkboxes (1.56 KB, patch)
2013-12-29 07:42 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11075 - 'select all' export clears renew checkboxes (1.71 KB, patch)
2013-12-29 08:22 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-10-17 16:56:12 UTC
[Discovered during testing the patch for bug 10884]

If circulation exports are enabled (by turning on ExportWithCsvProfile), the table on the checkout page includes three columns of checkboxes -- 'renew', 'checkin', and 'export'.

For each loan, the renew and checkout links should behave like radio buttons, but the state of the export checkbox is meant to be independent of the renew and checkin checkboxes.

However, if the 'select all' link in the export column is clicked, active renew checkboxes are toggled off.

The desired behavior is that clicking the select all link in the export column should only affect checkboxes in that column.
Comment 1 Jonathan Druart 2013-11-21 17:00:32 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-11-21 17:00:49 UTC
Galen, I took the liberty of copying your description in the commit message.
Comment 3 Chris Cormack 2013-12-29 07:42:04 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-12-29 08:22:00 UTC
Created attachment 23856 [details] [review]
[PASSED QA] Bug 11075 - 'select all' export clears renew checkboxes

If circulation exports are enabled (by turning on ExportWithCsvProfile),
the table on the checkout page includes three columns of checkboxes --
'renew', 'checkin', and 'export'.

For each loan, the renew and checkout links should behave like radio
buttons, but the state of the export checkbox is meant to be independent
of the renew and checkin checkboxes.

However, if the 'select all' link in the export column is clicked,
active renew checkboxes are toggled off.

The desired behavior is that clicking the select all link in the export
column should only affect checkboxes in that column.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script - one line JavaScript change.
Works as described.
Comment 5 Galen Charlton 2013-12-30 15:18:08 UTC
Pushed to master.  Thanks, Jonathan!
Comment 6 Fridolin Somers 2014-01-27 13:38:11 UTC
Patch pushed to 3.14.x, will be in 3.14.3.