Bug 11105 - label - opac - places on facets not easily css selectable
Summary: label - opac - places on facets not easily css selectable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Liz Rea
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 11312
  Show dependency treegraph
 
Reported: 2013-10-21 22:12 UTC by Rachel
Modified: 2015-06-04 23:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Adding span to Topics (1.08 KB, patch)
2013-10-21 22:53 UTC, Rachel
Details | Diff | Splinter Review
bug 11105 created topics span in opac (1.16 KB, patch)
2013-11-13 03:47 UTC, Liz Rea
Details | Diff | Splinter Review
bug 11105 created places span in opac (1.16 KB, patch)
2013-11-13 03:51 UTC, Liz Rea
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11105: created places span in opac (1.27 KB, patch)
2013-11-24 20:48 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11105: created places span in opac (1.33 KB, patch)
2013-11-27 15:18 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Rachel 2013-10-21 22:12:55 UTC
label - staff client - topics on facets not easily css selectable
Comment 1 Rachel 2013-10-21 22:53:45 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-10-21 23:31:05 UTC
This patch adds "<span id="topics-span"> Topics</span>" whereas other patches in this batch do something like this:

<span id="facet-Itemtypes"> Item types </span>

I think the "facet-XXX" pattern is better since it is more descriptive. It's redundant to give an id to your span which includes the word "span."

Thanks for the patch--I hope you can submit a follow-up.
Comment 3 Liz Rea 2013-11-13 03:31:19 UTC
Owen,
I'll fix this one up, maintaining Rachel's authorship.

Liz
Comment 4 Liz Rea 2013-11-13 03:47:27 UTC Comment hidden (obsolete)
Comment 5 Liz Rea 2013-11-13 03:51:51 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-11-24 20:48:52 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-11-27 15:18:39 UTC
Created attachment 23190 [details] [review]
Bug 11105: created places span in opac

To test:
Verify places in the facets is wrapped in a span.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Template change only, works as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2013-11-27 15:20:10 UTC
I think we would like to have an id for each facets, I will add a new report for that.

The patch will modify prog/bootstrap and intranet interfaces.
Comment 9 Galen Charlton 2013-11-27 17:57:04 UTC
Pushed to master.  Thanks, Rachel!
Comment 10 Fridolin Somers 2013-12-13 13:56:10 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1
Comment 11 Tomás Cohen Arazi 2013-12-23 15:19:52 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Rachel!