Bug 11106, bug 8989, bug 11105 add an id for facets. It should be similar for staff and opac (prog and bootstrap).
Created attachment 23191 [details] [review] Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id.
Created attachment 23192 [details] [review] Bug 11312: Facets should be selectable using an id [opac-prog]
Created attachment 23193 [details] [review] Bug 11312: Facets should be selectable using an id [opac-bootstrap]
*** Bug 11538 has been marked as a duplicate of this bug. ***
*** Bug 11546 has been marked as a duplicate of this bug. ***
Created attachment 24287 [details] [review] Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id.
Created attachment 24288 [details] [review] Bug 11312: Facets should be selectable using an id [opac-prog]
Created attachment 24289 [details] [review] Bug 11312: Facets should be selectable using an id [opac-bootstrap]
Created attachment 24309 [details] [review] Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id.
Created attachment 24310 [details] [review] signed-off Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
Created attachment 24311 [details] [review] signed-off Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
Created attachment 24312 [details] [review] signed-off Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
Created attachment 24377 [details] [review] Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
Created attachment 24378 [details] [review] Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
Created attachment 24379 [details] [review] Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right.
Created attachment 24380 [details] [review] Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
I added the Francesca's patch (from bug 11546).
I tested and saw some small issues that could be fixed in a follow up. As we don't have bootstrap in 3.12 the boostrap follow up would be best as a separate patch. INTRANET & PROG OPAC The span for the author facet is not closing correctly: +[% IF facets_loo.type_label_Authors %]<span id="facet-authors"Authors</span>[% END %] Also it would be nice, if all use were following the same naming schema. Most ids use a minus, but we have 2 using an underscore instead. BOOTSTRAP The HTML structure here is a bit different than for the other 2 themes. The patch adds a span inside a h5 tag. It would be cleaner, if we changed it, so the h5 tag has the id. In order to do that the <h5> before and the </h5> after the facet block can be deleted and the span has to be changed to h5. The result would look someting like this: [% IF ( facets_loo.type_label_Topics ) %]<h5 id="facets-Topics">Topics</h5>[% END %] We could also standardize the naming scheme a bit more, by using all lowercase ids. This way it would be the same ids for all 3 templates.
Created attachment 24445 [details] [review] Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
Created attachment 24446 [details] [review] Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
Created attachment 24447 [details] [review] Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right.
Created attachment 24448 [details] [review] Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore <francescalamoore@gmail.com>
(In reply to Katrin Fischer from comment #18) > INTRANET & PROG OPAC > The span for the author facet is not closing correctly Hum... (/me is hidden) > Also it would be nice, if all use were following the same naming schema. > Most ids use a minus, but we have 2 using an underscore instead. Yes of course! I don't know what I did... > BOOTSTRAP > The HTML structure here is a bit different than for the other 2 themes. The > patch adds a span inside a h5 tag. It would be cleaner, if we changed it, so > the h5 tag has the id. In order to do that the <h5> before and the </h5> > after the facet block can be deleted and the span has to be changed to h5. > The result would look someting like this: > > [% IF ( facets_loo.type_label_Topics ) %]<h5 > id="facets-Topics">Topics</h5>[% END %] > > We could also standardize the naming scheme a bit more, by using all > lowercase ids. This way it would be the same ids for all 3 templates. In fact I forgot to re-upload a patch for the bootstrap theme. It is why the code was completely different. I replaced the span with h5.
Created attachment 24531 [details] [review] Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. Signed-off-by: Francesca Moore <francescalamoore@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24532 [details] [review] Bug 11312: Facets should be selectable using an id [opac-prog] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24533 [details] [review] Bug 11312: facets labels are not css selectable -- opac-bootstrap To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 24534 [details] [review] Bug 11312: Facets should be selectable using an id [opac-bootstrap] Signed-off-by: Francesca Moore <francescalamoore@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Francesca and Jonathan!