Created attachment 22718 [details] [review] Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent.
Tried applying this patch in a sandbox and got this message: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11201: <h1>Something went wrong !</h1>Applying: Bug 11201: Add a in-house use list pages fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11201: Add a in-house use list pages When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11201 - List pending in-house uses 22718 - Bug 11201: Add a in-house use list pages Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11201-Add-a-in-house-use-list-pages-69ntjD.patch . Christopher
(In reply to Christopher Brannon from comment #2) > Tried applying this patch in a sandbox and got this message: This patch depends on bug 10859 and bug 10860. You must apply them before applying this one. That cannot be done with a sandbox.
Created attachment 31391 [details] [review] Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent.
Created attachment 31392 [details] [review] Bug 11201: Display lib instead of AV code This patch assumes that items.location is linked the the LOC authorised values.
Created attachment 31666 [details] [review] Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. Bug 11201: Display lib instead of AV code This patch assumes that items.location is linked the the LOC authorised values.
There a couple of things I would like to see added if possible: - Output of subtitles as defined in Keyword to MARC mapping - Overdue items highlighted in red as they are on the checkouts page
Created attachment 33185 [details] [review] Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red.
(In reply to Owen Leonard from comment #7) > - Output of subtitles as defined in Keyword to MARC mapping I don't want to add to much information on this table. But this could be done later if needed. > - Overdue items highlighted in red as they are on the checkouts page Done.
I am not seeing anything on my on site checkouts page and I do have an item checked out for onsite. Is there something else I need to do?
Created attachment 36278 [details] [review] Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red.
(In reply to Nicole C. Engard from comment #10) > I am not seeing anything on my on site checkouts page and I do have an item > checked out for onsite. Is there something else I need to do? Sorry Nicole, there was a syntax error in the sql query.
Created attachment 36471 [details] [review] [SIGNED-OFF] Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. Bug 11201: Display lib instead of AV code This patch assumes that items.location is linked the the LOC authorised values. Signed-off-by: Nicole <nicole@bywatersolutions.com>
Created attachment 36475 [details] [review] [SIGNED-OFF] Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red. Signed-off-by: Nicole <nicole@bywatersolutions.com>
Sorry :( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11201: Display overdues in red fatal: sha1 information is lacking or useless (C4/Circulation.pm). ...
Should be good now.
Comment on attachment 36471 [details] [review] [SIGNED-OFF] Bug 11201: Add a in-house use list pages Review of attachment 36471 [details] [review]: ----------------------------------------------------------------- Tiny tiny things... :) ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt @@ +46,4 @@ > systems with large numbers of overdue items.</li>[% END %] > <li> <a href="/cgi-bin/koha/circ/branchoverdues.pl">Overdues with fines</a> - Limited to your library. See report help for other details.</li> > <!-- <li> <a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">Daily reconciliation</a></li> --> > + <li><a href="/cgi-bin/koha/circ/on-site_checkouts.pl">On-site checkout list</a></li> Hi Jonathan, can you please make the visibility of the link depend on the system preference? ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt @@ +40,5 @@ > +<div id="doc3" class="yui-t2"> > + <div id="bd"> > + <div id="yui-main"> > + <div class="yui-b"> > + <h4>Pending on-site checkout list</h4> I think this should be <h1> as on the other pages - otherwise the 'no pending...' message is bigger than the heading. After discussing with Nicole it would be nice if the circulation start page and the heading both said: Pending on-site checkouts
Created attachment 36646 [details] [review] Bug 11201: qa-followup - move h4 to h1 - Make the link on the circ home page depending on the pref
Created attachment 36663 [details] [review] Bug 11201: qa-followup - move h4 to h1 - Make the link on the circ home page depending on the pref Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Created attachment 36914 [details] [review] [PASSED QA] Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. Bug 11201: Display lib instead of AV code This patch assumes that items.location is linked the the LOC authorised values. Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36915 [details] [review] [PASSED QA] Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red. Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36916 [details] [review] [PASSED QA] Bug 11201: qa-followup - move h4 to h1 - Make the link on the circ home page depending on the pref Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 36917 [details] [review] Bug 11201 - QA follow-up - Pending on-site checkouts Changes page name to "Pending on-site checkouts" as agreed during the hackfest. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!