Bug 15841 - Final truth value in C4:Circulation has become displaced
Summary: Final truth value in C4:Circulation has become displaced
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Colin Campbell
QA Contact: Testopia
URL:
Keywords:
Depends on: 11201
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-17 12:47 UTC by Colin Campbell
Modified: 2017-06-14 22:08 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (810 bytes, patch)
2016-02-17 12:52 UTC, Colin Campbell
Details | Diff | Splinter Review
Bug 15841 Circulation module's true value misplaced (985 bytes, patch)
2016-02-22 10:04 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 15841 Circulation module's true value misplaced (1.03 KB, patch)
2016-02-22 10:58 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2016-02-17 12:47:24 UTC
Last thing in a module should be a true value, looks as though a subroutine has been added after the one in circulation. Lets put it back where it should be
Comment 1 Colin Campbell 2016-02-17 12:52:28 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-02-22 10:04:28 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-02-22 10:58:00 UTC
Created attachment 48272 [details] [review]
Bug 15841 Circulation module's true value misplaced

1; was not at the end of the module as it should be
to ensure compilation returns true
return it to last line of code where it should be

This patch fixes an ovious mistake.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Marcel de Rooy 2016-02-22 12:55:45 UTC
Good catch.

> This patch fixes an ovious mistake.
:)
Comment 5 Brendan Gallagher 2016-02-24 03:05:35 UTC
Pushed to Master - Should be in the May 2016 release.  Thanks !
Comment 6 Julian Maurice 2016-02-26 15:44:19 UTC
Patch pushed to 3.22.x, will be in 3.22.4