Bug 11275 - make deleteditems.materials of type text
Summary: make deleteditems.materials of type text
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 7278
Blocks:
  Show dependency tree / graph
 
Reported: 2013-11-20 12:49 UTC by Fridolin Somers
Modified: 2015-06-04 23:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11275 - make deleteditems.materials of type text (2.10 KB, patch)
2013-11-20 13:35 UTC, Fridolin Somers 		Details | Diff | Splinter Review
[SIGNED OFF] Bug 11275 - make deleteditems.materials of type text (2.74 KB, patch)
2013-11-24 22:37 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 11275 - make deleteditems.materials of type text (2.87 KB, patch)
2013-11-27 15:51 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 11275 - make deleteditems.materials of type text (2.49 KB, patch)
2013-11-27 15:54 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-11-20 12:49:08 UTC 
Bug 7278 has made items.materials of type text.
It must be the same in deleteditems column.
Comment 1 Fridolin Somers 2013-11-20 13:35:31 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-11-24 22:27:36 UTC 
Fridolin, nothing about this patch, but noticing that it lookl like you are not using git-bz - I really recommend you look into it, it's amazingly helpful:
http://wiki.koha-community.org/wiki/Git_bz_configuration
Comment 3 Katrin Fischer 2013-11-24 22:37:38 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-11-27 15:51:25 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-11-27 15:53:09 UTC 
There is a problem with the patch! (SetVersion missing in updatedb).
New patch coming...
Comment 6 Jonathan Druart 2013-11-27 15:54:24 UTC 
Created attachment 23195 [details] [review]
Bug 11275 - make deleteditems.materials of type text

Bug 7278 has made items.materials of type text.
It must be the same in deleteditems column.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Tested:
- definition of materials now matches between items and deleteditems
- database update works correctly

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
The only difference between tables items and deleteditems is
deleteditems.marc
Amended patch: Add a missing SetVersion in updatedb.pl
Comment 7 Katrin Fischer 2013-11-27 16:08:29 UTC 
Ah, thx for catching that - probably my fault when fixing the conflict!
Comment 8 Galen Charlton 2013-11-27 17:54:09 UTC 
Pushed to master.  Thanks, Fridolin!
Comment 9 Fridolin Somers 2013-12-13 13:51:34 UTC 
This patch has been pushed to 3.14.x, will be in 3.14.1
(creates DBRev 3.14.00.002)
Comment 10 Tomás Cohen Arazi (tcohen) 2013-12-23 15:18:21 UTC 
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Fridolin!