Bug 7278 - In the items table, make items.materials of type text, and show its contents at circulation
Summary: In the items table, make items.materials of type text, and show its contents ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.8
Hardware: All All
: P3 enhancement (vote)
Assignee: Chris Cormack
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks: 11275
  Show dependency treegraph
 
Reported: 2011-11-30 01:27 UTC by Chris Cormack
Modified: 2013-11-20 12:49 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7728 : Materials Specified field made larger and displayed (5.54 KB, patch)
2011-11-30 21:50 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 7278 : Additional Materials (3.07 KB, patch)
2011-12-01 01:21 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 7278 : Additional Materials (3.11 KB, patch)
2011-12-04 20:23 UTC, Chris Cormack
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7728 : Materials Specified field made larger and displayed (6.18 KB, patch)
2011-12-20 07:45 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7278 : Additional Materials (3.18 KB, patch)
2011-12-20 07:45 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 7278: Follow up fixing display of item informaton on detail page (2.35 KB, patch)
2011-12-20 07:45 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 7278: Follow up fixing display of item informaton on detail page (2.41 KB, patch)
2011-12-20 08:40 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-11-30 01:27:45 UTC
Work to be done: 
* Alter database change items.material to text 
* Check 952 subfield 3 is linked to this 
* Make field editable in cataloguing 
* Make field display in catalogue/detail.pl 
* Make field display in circulation if non empty 

How to test: 
* Add a note in cataloguing 
* Check it displays at checkout and checkin 
* Check it displays on the staff catalogue detail page
Comment 1 Chris Cormack 2011-11-30 21:50:28 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-12-01 01:21:06 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2011-12-02 15:48:50 UTC
This works well for me, but I have a couple of suggesions. Here's the discussion on IRC:

[10:36]	<oleonard>	When I check out something which has a materials 
                        specified note, the checkout screen says "This item 
                        contains multiple parts: " + my note
[10:36]	<kf>	makes sense to me
[10:36]	<kf>	I think our libraries would use it for books with cds
[10:36]	<kf>	where the cds have no separate barcodes
[10:37]	<kf>	or language courses with cassettes/cds and booklets in a box
[10:37]	<oleonard>	jcamins: But you say that isn't necessarily accurate?
[10:37]	<jcamins>	oleonard: some libraries will use "materials specified" 
                        to indicate that they have only a portion of the item.
[10:37]	<jcamins>	For example, "first gathering."
[10:38]	<jcamins>	So, the item might have only one part, but the 
                        particular library doesn't have the whole thing.
[10:39]	<sekjal>	so, essentially, if you still think of this in terms of 
                        'number of parts', it's not a integer, but a rational 
                        number
[10:40]	<oleonard>	We need something less specific than "This item 
                        contains multiple parts: "
[10:41]	<oleonard>	"Note about the accompanying materials:" ?
[10:41]	<jcamins>	Makes sense to me.
[10:42]	<sekjal>	so long as the text is wrapped in a div with ID, we 
                        don't need to worry too much about the exact text
[10:42]	<sekjal>	so long as it's generically 'good enough'
[10:42]	<jcamins>	True.

- Can we change the prompt on checkout and checkin to the more generic "Note about the accompanying materials:" (or something similar) ?
- Can we add an ID to the message div so that the text can be modified via JavaScript?
Comment 4 Chris Cormack 2011-12-04 19:54:07 UTC
Will add the id and change the note text
Comment 5 Chris Cormack 2011-12-04 20:23:19 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2011-12-20 07:45:25 UTC
Created attachment 6881 [details] [review]
[SIGNED-OFF] Bug 7728 : Materials Specified field made larger and displayed

This first page makes the database change, and displays the field on
the detail.pl and moredetail.pl pages in the staff client

How to Test:

* Add a note to the materials specified page in cataloguing (952
subfield 3 for MARC21, but it shouldn't matter as long as you have a
field mapped to items.materials
* Check it displays at catalogue/detail.pl
* Check it displays at catalogue/moredetail.pl

Patch to follow to have the note display at checkin/checkout

http://bugs.koha-community.org/show_bug.cgi?id=7278

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed conflicts in updatedatabase.pl and kohastructure.sql
Comment 7 Katrin Fischer 2011-12-20 07:45:37 UTC
Created attachment 6882 [details] [review]
[SIGNED-OFF] Bug 7278 : Additional Materials

Part 2: This patch shows the message at checkout and checkin

How to test:
* Add a note in cataloguing
* Check it displays at checkout and checkin
* Check items without a note don't display anything

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 8 Katrin Fischer 2011-12-20 07:45:44 UTC Comment hidden (obsolete)
Comment 9 Chris Cormack 2011-12-20 08:40:11 UTC
Created attachment 6885 [details] [review]
Bug 7278: Follow up fixing display of item informaton on detail page

Fixes a display problem in the item table on staff detail page.

To test:
Add a record with 3 items:
- 1 with copynumber
- 1 with materials specified
- 1 with opac notes

Before patch the table will be broken a bit and the headings
don't match the contents (wrong sequence).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 10 Ian Walls 2011-12-21 19:46:28 UTC
All three patches together are solid, consistent, and any display issues with tables are resolved.  Extending varchar(10) to text is safe and loss-less.  Glad and easy to read, marking as Passed QA
Comment 11 Paul Poulain 2012-01-10 22:00:47 UTC
prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok     

prove xt/author/translatable-templates.t
xt/author/translatable-templates.t .. ok   

patch pushed, please test
Comment 12 Katrin Fischer 2012-02-07 16:01:08 UTC
Successfully tested in 3.6.3 - latest stable release.