I noticed today that the "Continues:" label is missing a space after the label on the bootstrap theme. This has been fixed a while ago on the prog theme - I think easiest would be to copy the XSLT files, so both filesets are current.
Created attachment 23972 [details] [review] Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
I think it would be reasonable to consider making the OPAC XSLT stylesheets not be specific to a particular theme, but instead be shared by all of them. Even if that's the final decision, I think it would be a good idea for this patch to be reviewed and pushed, as having the XSLT be identical in the two major themes prior to moving it will make it easier to validate the consolidation.
(In reply to Galen Charlton from comment #2) > I think it would be reasonable to consider making the OPAC XSLT stylesheets > not be specific to a particular theme, but instead be shared by all of them. > Even if that's the final decision, I think it would be a good idea for this > patch to be reviewed and pushed, as having the XSLT be identical in the two > major themes prior to moving it will make it easier to validate the > consolidation. +1 Personally, I don't see a need to duplicate XSLTs across the different themes. I think it just adds more chance of error. In theory, someone might want to tie an XSLT to a theme, so that different themes show different data, but I don't see the purpose of that, since we can already specify different XSLTs in the system preferences. Reduce the boilerplate, me thinks.
Created attachment 25314 [details] [review] Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
*** Bug 11758 has been marked as a duplicate of this bug. ***
Created attachment 25376 [details] [review] Bug 11310: update the XSLT for the Bootstrap theme When the Bootstrap theme was started, the XSLT directory was copied over from the prog theme. However, it was not kept up to date with respect to changes to prog's XSLT. This patch rectifies the problem by copying over the current state of prog/en/xslt to bootstrap/en/xslt. As a consequence, the following bugs or enhancements should now be reflected in the Bootstrap theme: * 6886 * 10905 * 10465 * 10564 * 10793 * 10218 * 6594 * 9820 * 10745 * 6553 * 10218 * 10284 To test: [1] Apply the patch and ensure that OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are set to 'default' and that OPAC theme is set to 'bootstrap'. [2] Ensure that OPAC results and bib details look OK. [3] To be really thorough, run through the test plans for the other bugs referenced by this patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> diff -w bootstrap/en/xslt/XXX prog/en/xslt/XXX returns no difference.
Pushed to master.
As this bug addresses regressions from the prior default theme to the new default theme in 3.14, will the patch also be backported to 3.14?
Hi Dan, as this is marked as bug (vs. enhancement or new feature) it is likely to be backported to earlier versions, but it's up to the RMaint to make the decision.
Pushed to 3.14.x, will be in 3.14.08
There was no pb backporting this bug. I've just waited a bit because of previous string freeze.