Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows, as well as the "sticky" feature. It is trivial to restore this functionality. These datatables are already using bStateSave, so are they are "sticky" already. The only part left is to enable the ability to limit the table to 5 rows at a time.
Created attachment 23200 [details] [review] Bug 11314 - Restore ability to see only 5 entries on parcel.pl Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows, as well as the "sticky" feature. It is trivial to restore this functionality. These datatables are already using bStateSave, so are they are "sticky" already. The only part left is to enable the ability to limit the table to 5 rows at a time. Test Plan: 1) Apply this patch 2) Browse to parcel.pl 3) Note the default rows count is still 10 4) Note the option to limit the row count to 5
Created attachment 24559 [details] [review] Bug 11314 - Restore ability to see only 5 entries on parcel.pl Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows, as well as the "sticky" feature. It is trivial to restore this functionality. These datatables are already using bStateSave, so are they are "sticky" already. The only part left is to enable the ability to limit the table to 5 rows at a time. Test Plan: 1) Apply this patch 2) Browse to parcel.pl 3) Note the default rows count is still 10 4) Note the option to limit the row count to 5 Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Double-checked that the "sticky" feature is still in place thanks to bStateSave. I didn't notice a difference due to iDisplayLength being added, but the extra option of "5" to the list is there.
Created attachment 24692 [details] [review] Bug 11314 - Restore ability to see only 5 entries on parcel.pl Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows, as well as the "sticky" feature. It is trivial to restore this functionality. These datatables are already using bStateSave, so are they are "sticky" already. The only part left is to enable the ability to limit the table to 5 rows at a time. Test Plan: 1) Apply this patch 2) Browse to parcel.pl 3) Note the default rows count is still 10 4) Note the option to limit the row count to 5 Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Double-checked that the "sticky" feature is still in place thanks to bStateSave. I didn't notice a difference due to iDisplayLength being added, but the extra option of "5" to the list is there. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24693 [details] [review] Bug 11314: Make "All" translatable Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I am not sure to understand what bStateSave does. If I click on the "Filter" button (on the left side of parcel.pl), the value become again the default value (10). Since bug 11555 and bug 11605 make "All" translatable, I added a followup to keep the translation on this page. Marked as Passed QA.
Pushed to master. Thanks, Kyle!
Patches pushed to 3.14.x, will be in 3.14.06