Some libraries would like the following enhancements to the inventory tool: 1) Have the tool warn of items possibly shelved out of order for scanned lists of barcodes ( by comparing to previous and next items ). 2) Ability to skip items with waiting holds ( in the same manners as items on issue are skipped ). 3) The ability to choose locations to not flag as "Item should have been scanned" if not scanned ( e.g. On Shelving Cart, On Display, etc )
Created attachment 23582 [details] [review] Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order
Created attachment 23583 [details] [review] Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously
Created attachment 23584 [details] [review] Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses".
Created attachment 23585 [details] [review] Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display.
Created attachment 23586 [details] [review] Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic.
Created attachment 23587 [details] [review] Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned"
Created attachment 24173 [details] [review] Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order
Created attachment 24174 [details] [review] Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously
Created attachment 24175 [details] [review] Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses".
Created attachment 24176 [details] [review] Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display.
Created attachment 24177 [details] [review] Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic.
Created attachment 24178 [details] [review] Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned"
Created attachment 25037 [details] [review] Bug 11405 [7] - Add out of order status to CSV file
Applying: Bug 11405 [1] - Warn of items possibly scanned out of order Applying: Bug 11405 [2] - Skip items with waiting holds Applying: Bug 11405 [3] - Update item status fieldset string to be more descriptive fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11405 [3] - Update item status fieldset string to be more descriptive
Created attachment 31250 [details] [review] Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order
Created attachment 31251 [details] [review] Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously
Created attachment 31252 [details] [review] Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses".
Created attachment 31253 [details] [review] Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display.
Created attachment 31254 [details] [review] Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic.
Created attachment 31255 [details] [review] Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned"
Created attachment 31256 [details] [review] Bug 11405 [7] - Add out of order status to CSV file
I'm trying this patch. Ok for [1] (mervelous!!) For [2], I will try again because message "No data available in table" (and normally it's all right). Ok for [3]. I just have to try csv file.
Comment on attachment 31251 [details] [review] Bug 11405 [2] - Skip items with waiting holds Review of attachment 31251 [details] [review]: ----------------------------------------------------------------- ::: tools/inventory.pl @@ +233,4 @@ > if ( $markseen or $op ) { > # retrieve all items in this range. > my $totalrecords; > + ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $ignore_holds_waiting, '', $branchcode, $branch, 0, undef , $staton); This is where a nasty conflict shows up. Please rebase.
Created attachment 40572 [details] [review] Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order
Created attachment 40573 [details] [review] Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously
Created attachment 40574 [details] [review] Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses".
Created attachment 40575 [details] [review] Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display.
Created attachment 40576 [details] [review] Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic.
Created attachment 40577 [details] [review] Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned"
Created attachment 40578 [details] [review] Bug 11405 [7] - Add out of order status to CSV file
Comment on attachment 40572 [details] [review] Bug 11405 [1] - Warn of items possibly scanned out of order Review of attachment 40572 [details] [review]: ----------------------------------------------------------------- ::: tools/inventory.pl @@ +373,5 @@ > my @results; > +@results = > + $uploadbarcodes ? @items_with_problems > + : $op ? @$inventorylist > + : undef; Nested ? operators is ugly. Could we improve readability here?
Comment on attachment 40577 [details] [review] Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned Review of attachment 40577 [details] [review]: ----------------------------------------------------------------- ::: C4/Items.pm @@ +1164,4 @@ > # Auth values > foreach (keys %$row) { > if (defined($avmapping->{"items.$_,".$row->{'frameworkcode'}.",".$row->{$_}})) { > + $row->{"$_-code"} = $row->{$_}; Though not required by PERL17 of the Coding Guidelines, a test would be nice.
(In reply to Kyle M Hall from comment #1) > Created attachment 23582 [details] [review] [review] > Bug 11405 [1] - Warn of items possibly scanned out of order > > This patch addes the ability to choose to be warned if it's possible > an item was scanned out of order ( i.e. mis-shelved ). > > Test Plan: > 1) Apply this patch > 2) Generate a list of barcodes ordered by callnumber > 3) "Misplace" one callnumber by moving it to another area of the list > 4) Browse to the inventory tool, choose your barcodes file > 5) Check the checkbox for "Check barcodes list for items shelved out of > order" > 6) Click "submit", note the item has been flagged as possibly out of order Hi Everyone, When I attempt to test this bug on one of the Koha sandboxes, the Koha instance fails to load and the following message was emailed to me: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11405: <h1>Something went wrong !</h1>Applying: Bug 11405 [1] - Warn of items possibly scanned out of order Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging tools/inventory.pl CONFLICT (content): Merge conflict in tools/inventory.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Failed to merge in the changes. Patch failed at 0001 Bug 11405 [1] - Warn of items possibly scanned out of order When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11405 - Inventory tool enhancements 40572 - Bug 11405 [1] - Warn of items possibly scanned out of order 40573 - Bug 11405 [2] - Skip items with waiting holds 40574 - Bug 11405 [3] - Update item status fieldset string to be more descriptive 40575 - Bug 11405 [4] - Allow long labels to be less word-wrapped 40576 - Bug 11405 [5] - Fix html fieldset weirdness 40577 - Bug 11405 [6] - Allow items with selected locations to be not be flagged as Item should have been scanned if not scanned 40578 - Bug 11405 [7] - Add out of order status to CSV file Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11405-1---Warn-of-items-possibly-scanned-out-o-sHNWpq.patch FWIW, Christopher
This patch doesn't apply, I have changed the patch status accordingly. Please also note: 'Inventory tool enhancements' is a suspicious title for a bug and I usually take it as a sign that a patch tries to do a multitude of things at once where it would be nicer to have separated patches for each thing! ;)
Created attachment 47027 [details] [review] Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order
Created attachment 47028 [details] [review] Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously
Created attachment 47029 [details] [review] Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses".
Created attachment 47030 [details] [review] Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display.
Created attachment 47031 [details] [review] Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic.
Created attachment 47032 [details] [review] Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned"
Created attachment 47033 [details] [review] Bug 11405 [7] - Add out of order status to CSV file
Created attachment 47035 [details] [review] Bug 11405 [1] - Warn of items possibly scanned out of order This patch addes the ability to choose to be warned if it's possible an item was scanned out of order ( i.e. mis-shelved ). Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) "Misplace" one callnumber by moving it to another area of the list 4) Browse to the inventory tool, choose your barcodes file 5) Check the checkbox for "Check barcodes list for items shelved out of order" 6) Click "submit", note the item has been flagged as possibly out of order
Created attachment 47036 [details] [review] Bug 11405 [2] - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously
Created attachment 47037 [details] [review] Bug 11405 [3] - Update item status fieldset string to be more descriptive The inventory tool has a fieldset title "Item status" but does not explain what selecting item statuses does. This fieldset legend should be updated to explain what these checkboxes do. This patch changes the legend from "Item statuses" to "Limit to items matching all the following statuses".
Created attachment 47038 [details] [review] Bug 11405 [4] - Allow long labels to be less word-wrapped The labels in the last fieldset of the inventory tool are a bit "squashed" and are word wrapped to many lines unnecessarily. This patch adds an additional css style for fieldsets of the class "row". If an additional class "wide" as added to the fieldset, it will give the labels more room for display.
Created attachment 47039 [details] [review] Bug 11405 [5] - Fix html fieldset weirdness For unknown and unnecessary reasons, the inventory tool display will attempt to merge the "select items you want to check" fieldset with the bottom fieldset if no statuses are present. This situation is highly unlikely and complicates the template logic.
Created attachment 47040 [details] [review] Bug 11405 [6] - Allow items with selected locations to be not be flagged as "Item should have been scanned" if not scanned This patch allows items to be skipped over if the item has one of the locations selected in the new field set listing shelving locations. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Set one of those items to a shelving location 4) Remove that item from the list 5) Run the inventory tool with this list of barcodes 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned"
Created attachment 47041 [details] [review] Bug 11405 [7] - Add out of order status to CSV file
It would be handy if Kyle could recheck this too. :) I have merely made it applicable and tried to match old code differences. I have not tested it.
Created attachment 47106 [details] [review] Bug 11405 [7] - Add out of order status to CSV file Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Working on the test plan, I was not able to get it to pass using the sandbox. Compare barcodes list to results doesn't work. Tried using an txt file with 5 items in it. There are 6 items with the call number FIC. I get stuck on number 6. 6) Note the item is listed as "should have been scanned" 7) Click back to return to the previous page 8) Select the shelving location from "If comparing barcodes list to results, assume items with the following locations should note have been scanned". 8) Re-run the inventory tool 9) Note the item is no longer listed as "should have been scanned
Applying: Bug 11405 [1] - Warn of items possibly scanned out of order Applying: Bug 11405 [2] - Skip items with waiting holds Applying: Bug 11405 [3] - Update item status fieldset string to be more descriptive Applying: Bug 11405 [4] - Allow long labels to be less word-wrapped fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11405 [4] - Allow long labels to be less word-wrapped Very sorry to say the last patch doesn't apply any more.