Created attachment 79432 [details] [review] Bug 21413: Unit tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Items/GetItemsForInventory.t => FAIL: Tests fail! - Apply the next patches on the bug - Run: k$ prove t/db_dependent/Items/GetItemsForInventory.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 79433 [details] [review] Bug 21413: Inventory - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Writing patches under another name? :)
(In reply to Marcel de Rooy from comment #3) > Writing patches under another name? :) I'm splitting bug 11405. On this one I added tests too.
Created attachment 81376 [details] [review] Bug 21413: Unit tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Items/GetItemsForInventory.t => FAIL: Tests fail! - Apply the next patches on the bug - Run: k$ prove t/db_dependent/Items/GetItemsForInventory.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81377 [details] [review] Bug 21413: Unit tests To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Items/GetItemsForInventory.t => FAIL: Tests fail! - Apply the next patches on the bug - Run: k$ prove t/db_dependent/Items/GetItemsForInventory.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81378 [details] [review] Bug 21413: Inventory - Skip items with waiting holds This patch enables items to be skipped for inventory stocktaking if the item is currently a waiting hold. The intention is to skip items that should be on the holds waiting shelf in the library. Test Plan: 1) Apply this patch 2) Generate a list of barcodes ordered by callnumber 3) Select one of those items and place it on hold, then confirm the hold 4) Remove that barcode from the list of barcodes 5) Browse to the inventory tool, choose your barcodes file 6) Run the inventory tool with that barcode file. 7) Note the tool says that item should have been scanned 8) Click the browsers back button to return to the previous page 9) Check the checkbox for "Skip copies marked as waiting holds" 10) Run the tool again, not it does not flag that item as previously Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 81379 [details] [review] Bug 21413: (QA follow-up) Rename new option Trying to make the terminology a little more consistent as we already use items instead of copies directly above and leaning on the description of the page it refers to. Old: Skip copies marked as waiting holds New: Skip items on hold awaiting pickup Skip items on hold awaiting pickup
Last patch is a suggestion, leaving it to native-speaker RM to decide :)
Created attachment 82040 [details] [review] Bug 21413: Fix condition to avoid operator bnding isssues The original WHERE condition wasn't enclosed in parenthesis, and hence was subject to binding precedence issues in some situations. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome work all! Pushed to master for 18.11
Created attachment 82111 [details] [review] Bug 21413: Call AddBiblio in list context Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(In reply to Tomás Cohen Arazi from comment #12) > Created attachment 82111 [details] [review] [review] > Bug 21413: Call AddBiblio in list context > > Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Follow up pushed to master
Created attachment 82168 [details] [review] Bug 21413: (QA follow-up) Fix tests No assumption on the order in which restults are returned should be made (we don't control existing data on the tests). So it should only check existence of expected records in the results, and absense. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
The enhancement will not be backported to 18.05.x series.