Created attachment 23615 [details] Before the patch Hi, As you can see in the first attached image the welcome statement and the logout link is located to the right of the screen, but in the right to left languages it must be to the left.
Created attachment 23616 [details] [review] Bug-11411-ENH-Bootstrap-theme-enhancement-for right to left This patch will make a small change on the bootstrap-rtl.min.css file to make the welcome statement and the logout link located to the left of the screen. Test plan : 1-apply the patch 2-translate install ar-Arab . and that's it .
Created attachment 23617 [details] After the patch The results must be as the attached image .
Created attachment 23883 [details] [review] Bug 11411 [ENH] Bootstrap theme (enhancement) for (right to left) This patch will make a small change on the bootstrap-rtl.min.css file to make the welcome statement and the logout link located to the left of the screen. Test plan : 1-apply the patch 2-translate install ar-Arab 3-check the login/logut is on the left and that's it. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
This works nicely, but not sure if it touches the necessary files. I see there is also /koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.css. Adding Owen in cc as he will know and I hope for some hints :)
(In reply to Katrin Fischer from comment #4) > This works nicely, but not sure if it touches the necessary files. I see > there is also /koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.css. Yeah there is a better way to handle this, although no one can be blamed for not knowing it because I haven't done a good job of laying out the guidelines. Two main points to consider: 1. No changes should be made to the files in bootstrap/lib unless they are "official upgrades" to these files, which are all created and maintained outside of the Koha project. If bootstrap-rtl.css has an error it and there isn't an "official upgrade" then the correction needs to be applied in Koha's custom RTL CSS. 2. All CSS in the Bootstrap theme is generated from LESS files (in bootstrap/less), so changes to CSS should be done in the LESS file. There is a specific rtl CSS file there: bootstrap/less/right-to-left.less, where this patch's changes should be made. Then the less file should be compiled and the resulting file put in bootstrap/css.
Owen, could you maybe provide a patch here? I am not sure anyone else understands how this works right now (including me) :)
Created attachment 24903 [details] [review] Bug 11411 - Bootstrap theme (enhancement) for (right to left) This patch improves Koha's layout when a right-to-left language is being displayed by correcting a float set by the right-to-left version of Bootstrap CSS. The patch modifies the right-to-left Less file and includes a now-minified version of the compiled CSS. To test, install a right-to-left language like ar-Arab. Apply the patch and view the OPAC under the Bootstrap theme. When logged in, the aligned to the left.
Created attachment 25090 [details] [review] Bug 11411 - Bootstrap theme (enhancement) for (right to left) This patch improves Koha's layout when a right-to-left language is being displayed by correcting a float set by the right-to-left version of Bootstrap CSS. The patch modifies the right-to-left Less file and includes a now-minified version of the compiled CSS. To test, install a right-to-left language like ar-Arab. Apply the patch and view the OPAC under the Bootstrap theme. When logged in, the aligned to the left. Signed-off-by: Holger Meißner <h.meissner.82@web.de>
Works as described.
Created attachment 25131 [details] [review] Bug 11411 - Bootstrap theme (enhancement) for (right to left)
Created attachment 25132 [details] [review] Bug 11411 [QA Followup] - Tidy css to restore readability
I have pushed Owen's original patch, but I'm declining to push the follow-ups supplied by Kyle because they defeat the (network performance) purpose of the minification. Also, in this case I don't think we want the compiled CSS to be readable, since one /should/ be editing the LESS files. That said, I'm not setting this decision in concrete, as only time will tell whether the benefits of minifying the CSS file outweigh the stumbling blocks for folks using a browser CSS debugger. However, I will point out that Chrome, at least, includes a pretty-print function in its debugger. Thanks, Owen!