We should create parity between the LESS and CSS folders in the Bootstrap theme. CSS should be minified to discourage hand editing. Steps to this available at http://www.lesscss.org/#usage Note that you will need to install Node.js first: http://nodejs.org/ A convenient tool for development with less: https://github.com/jonycheung/Dead-Simple-LESS-Watch-Compiler We should probably also start a wiki page to point people to on how to modify core less files in the bootstrap theme.
Created attachment 24631 [details] [review] Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified
Everything looks good except one file: This patch adds "jquery.css," which seems to be a renamed version of jquery.rating.css. Was this an error from the Less compile process?
hmm possibly, I'll have a check. Liz
Created attachment 25040 [details] [review] Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified
Wanted to test, patch does not apply.
Owen, No, I looked in master and that jquery file is there in the css for bootstrap, but not in the less, and it's called jquery.css. If it's not supposed to be there, I'll happily remove it. However, the newest attached patch left it alone. Liz
Created attachment 25832 [details] [review] Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified
To test: Verify the bootstrap theme still works as it should. -- MV: OK In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory -- MV:OK verify that all CSS files have been minified --MV: Not minified files found in koha-tmpl/opac-tmpl/bootstrap/css datatable.css opac.css opac-old.css
Created attachment 25876 [details] [review] Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified
Created attachment 25880 [details] [review] [Signed-off] Bug 11601 - creating parity between less and css folders, minifying CSS To test: Verify the bootstrap theme still works as it should. In the bootstrap theme files: verify that all CSS files have a counterpart in the less directory verify that all CSS files have been minified Followed test plan. OK. Signed-off-by: Marc Véron <veron@veron.ch>
It seems that mixings.css and sco-old.css are not used. Maybe should we remove them too? Owen, could you confirm that?
> It seems that mixings.css and sco-old.css are not used. > Maybe should we remove them too? opac-old.css and sco-old.css are unwanted byproducts of my development process and should not have been committed. They should be removed. responsive.css and mixins.css are byproducts of the automatic LESS build process and should not be added (they are currently not in git).
I think this one is long fixed now.