Bug 11546 - facets labels are not css selectable
Summary: facets labels are not css selectable
Status: RESOLVED DUPLICATE of bug 11312
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-14 01:44 UTC by Francesca
Modified: 2014-01-15 09:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
propose patch (3.06 KB, patch)
2014-01-14 01:47 UTC, Francesca 		Details | Diff | Splinter Review
bug 11546 facets labels are not css selectable (3.11 KB, patch)
2014-01-14 02:36 UTC, Aleisha Amohia 		Details | Diff | Splinter Review
bug 11546 facets labels are not css selectable (3.33 KB, patch)
2014-01-14 06:10 UTC, David Cook 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Francesca 2014-01-14 01:44:31 UTC 
add span tags to h5 headings to make them easily selectable in css
Comment 1 Francesca 2014-01-14 01:47:59 UTC Comment hidden (obsolete)
Comment 2 Aleisha Amohia 2014-01-14 02:36:05 UTC Comment hidden (obsolete)
Comment 3 David Cook 2014-01-14 06:10:49 UTC 
Created attachment 24269 [details] [review]
bug 11546 facets labels are not css selectable

To test:
1. search in OPAC directory
2. inspect the facets, note that they now have spans

Signed-off-by: David Cook <dcook@prosentient.com.au>

Works as described.

I'm not sure that this change is necessary, since the parent li elements
have IDs that can be hooked onto for CSS, but it doesn't change existing
behaviour and more control is always nice, so that's all right.
Comment 4 Jonathan Druart 2014-01-14 15:33:49 UTC 
I create a patch for that in bug 11312.

*** This bug has been marked as a duplicate of bug 11312 ***
Comment 5 Chris Cormack 2014-01-14 17:39:36 UTC 
Francesca, 

Perhaps you could test Jonathan's patch on bug 11312, and sign off on that. Which I'm sure Jonathan would appreciate.

And we will find a new bug to get your first patch into Koha.
Comment 6 Jonathan Druart 2014-01-15 09:03:53 UTC 
It seems I was a little bit boorish, I am sorry Francesca. I did not see it was your first patch!
I will add it on bug 11312.
Thank you for your signoff!