Bug 11663 - Bootstap theme opac holding tab improperly displayed when opacbookbag syspref is disabled
Summary: Bootstap theme opac holding tab improperly displayed when opacbookbag syspref...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Frédéric Demians
QA Contact: Testopia
URL:
Keywords:
: 12319 12422 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-01 08:47 UTC by Frédéric Demians
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.41 KB, patch)
2014-02-01 08:53 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled (2.46 KB, patch)
2014-02-01 21:04 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled (2.75 KB, patch)
2014-02-02 11:22 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Demians 2014-02-01 08:47:39 UTC
Bootstap theme opac holding tab is improperly displayed when opacbookbag syspref is disabled, and virtualshelf is enabled. This is due to the fact that in this situation basket.js is loaded (for virtual shelves), but some JS variable are not defined in template since opacbookbag is disabled.

To reproduce this bug:

- Choose bootstrap OPAC theme
- Enable virtualsheves syspref
- Disable opacbookbag syspref
- Open a biblio record in OPAC detail page
- You will observe that items holding tabs are not displayed as tabs but
  as a buletted list
Comment 1 Frédéric Demians 2014-02-01 08:53:56 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-01 21:04:03 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-02-02 11:22:33 UTC
Created attachment 24982 [details] [review]
[PASSED QA] Bug 11663: Bootstap opac holding tab improperly displayed when opacbookbag syspref is disabled

Bootstap theme opac holding tab is improperly displayed when opacbookbag
syspref is disabled, and virtualshelf is enabled. This is due to the fact that
in this situation basket.js is loaded (for virtual shelves), but some JS
variables are not defined in template since opacbookbag is disabled.

To reproduce this bug:

- Choose bootstrap OPAC theme
- Enable virtualsheves syspref
- Disable opacbookbag syspref
- Open a biblio record in OPAC detail page
- You will observe that items holding tabs are not displayed as tabs but
  as a buletted list

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script and all tests.
Confirmed display problem exists without the patch and is solved by it.
Ideally we would avoid having the cart messages in the template when
the feature is deactivated, but this is ok for now.
Comment 4 Galen Charlton 2014-02-04 18:02:45 UTC
Pushed to master.  Thanks, Frédéric!
Comment 5 Fridolin Somers 2014-05-16 08:16:30 UTC
Pushed to 3.14.x, will be in 3.14.07
Comment 6 Owen Leonard 2014-06-26 19:45:48 UTC
*** Bug 12319 has been marked as a duplicate of this bug. ***
Comment 7 Owen Leonard 2014-07-01 19:48:39 UTC
*** Bug 12422 has been marked as a duplicate of this bug. ***