Bug 11671 - Restructure patron lists add form for improved usability
Summary: Restructure patron lists add form for improved usability
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/patron_lists/list.pl?pa...
Keywords:
: 11664 (view as bug list)
Depends on: 11636
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-03 17:15 UTC by Owen Leonard
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11671 - Restructure patron lists add form for improved usability (8.73 KB, patch)
2014-02-03 19:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11671 - Restructure patron lists add form for improved usability (8.73 KB, patch)
2014-02-03 19:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11671 - Restructure patron lists add form for improved usability (8.60 KB, patch)
2014-02-21 13:59 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 11671 - Restructure patron lists add form for improved usability (8.75 KB, patch)
2014-03-06 16:40 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 11671 - Restructure patron lists add form for improved usability (8.84 KB, patch)
2014-03-16 20:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-03 17:15:35 UTC
I think it's a potential usability problem that the patron lists "add patron" form has a duplicated submit button. Having one button placed at the top next to the add function implies that this button might be *only* submitting the new patrons, not the deletions which could be triggered by having checked a checkbox.

I think the process of adding a patron should trigger the display of an "add" submit button which only submits the additions, not any deletions. The button at the bottom of the list should be clearly labeled and only submit deletions.
Comment 1 Owen Leonard 2014-02-03 19:34:08 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-02-03 19:42:49 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-02-03 19:43:52 UTC
Should have made this dependent on Bug 11636 since they conflict. Resubmitted and added the dependency.
Comment 4 Owen Leonard 2014-02-05 16:18:19 UTC
*** Bug 11664 has been marked as a duplicate of this bug. ***
Comment 5 Owen Leonard 2014-02-21 13:59:27 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2014-02-21 13:59:44 UTC
Rebased on current master.
Comment 7 Marc Véron 2014-03-06 16:40:23 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2014-03-16 20:02:51 UTC
Created attachment 26387 [details] [review]
[PASSED QA] Bug 11671 - Restructure patron lists add form for improved usability

Non-standard interface features have the potential to cause confusion.
This patch brings various aspects of the patron lists add page into
conformity with other staff client pages.

- Add "select all/clear all" links for the checkboxes
- Add a "remove selected" to the top of the table (see also Lists)
- Split functionality of add from from delete form
- Hide "Add patrons" button until at least one patron has been selected
- Remove non-standard trash can icon from table's checkbox column
- Exclude checkbox column from table sorting
- Add confirmation to deletion actions
- Improve breadcrumb specificity
- Add title-string sorting to date column to accommodate sorting for all
  date format types

To test, apply the patch and create a patron list.

1. Search for and select patrons for the list. Selecting a patron should
   trigger the display of an "Add patrons" button.
2. Click "Add patrons" and confirm that the add process completes
   correctly.
3. Search for and select a patron and also check the box next to an
   existing patron. Click "Add patrons" and confirm that no patron is
   removed.
4. Check that the "select all" and "clear all" links work correctly.
5. Select patrons on the list and click the "Remove selected" link. You
   should be prompted to confirm your choice.
   4.a. Click cancel and confirm that the deletion process aborts.
   4.b. Click OK and confirm that the deletion process completes.
6. Repeat step 4 with the "Remove selected patrons" at the bottom of the
   page.
7. Confirm that the page title and breadcrumbs correctly show the list
   name.
8. Switch between us and metric dateformat settings and confirm that
   table sorting by date is correct in both cases.

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no regressions found.
Comment 9 Galen Charlton 2014-03-26 20:04:59 UTC
Pushed to master.  Thanks, Owen!
Comment 10 Fridolin Somers 2014-07-11 06:52:44 UTC
Pushed to 3.14.x, will be in 3.14.09