Bug 11636 - Impossible to remove patrons from patron list during add process
Summary: Impossible to remove patrons from patron list during add process
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P3 normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 11632 11645 (view as bug list)
Depends on:
Blocks: 11632 11671
  Show dependency treegraph
 
Reported: 2014-01-29 17:07 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11636 - Impossible to remove patrons from patron list during add process (2.71 KB, patch)
2014-01-29 17:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11636 - Impossible to remove patrons from patron list during add process (2.73 KB, patch)
2014-01-30 19:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11636 - Impossible to remove patrons from patron list during add process (2.85 KB, patch)
2014-02-02 13:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-01-29 17:07:39 UTC
This problem affects libraries where patron card numbers include leading zeroes, for example "0001234." To reproduce:

1. If necessary, create or modify a patron to have a card number 
   with leading zeroes.
2. Go to Tools -> Patron lists.
3. Click "Add patrons" on an existing list.
4. Perform a patron search and choose one of the results.
5. Click the "remove" link next to the patron name which was just added.
   Nothing will happen.

See also Bug 11534.
Comment 1 Owen Leonard 2014-01-29 17:31:42 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-01-30 19:49:26 UTC
*** Bug 11645 has been marked as a duplicate of this bug. ***
Comment 3 Kyle M Hall 2014-01-30 19:59:57 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-02-02 13:39:47 UTC
*** Bug 11632 has been marked as a duplicate of this bug. ***
Comment 5 Katrin Fischer 2014-02-02 13:51:29 UTC
Created attachment 24986 [details] [review]
[PASSED QA] Bug 11636 - Impossible to remove patrons from patron list during add process

If you patrons have card numbers with leading zeroes this causes
problems removing patron entries during the process of adding patrons to
an existing list. This patch refactors the relevant JavaScript to
correct the problem and to remove inline "onclick" from generated HTML.

This patch also includes a fix for Bug 11632 - Untranslatable string
"Remove" in patron lists.

To test:

1. If necessary, create or modify a patron to have a card number
   with leading zeroes.
2. Go to Tools -> Patron lists.
3. Click "Add patrons" on an existing list.
4. Perform a patron search and choose one of the results.
5. Click the "remove" link next to the patron name which was just added.
   Nothing will happen.
6. Apply the patch and test again. The "remove" link should now work.

To test the fix for Bug 11632, after applying the patch run "translate
update [language code]" and confirm that the "Remove" string is listed
in the updated po file for patron_lists/list.tt.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, works as described.
Comment 6 Galen Charlton 2014-02-04 18:35:22 UTC
(In reply to Owen Leonard from comment #0)
> This problem affects libraries where patron card numbers include leading
> zeroes, for example "0001234." To reproduce:
> 
> 1. If necessary, create or modify a patron to have a card number 
>    with leading zeroes.
> 2. Go to Tools -> Patron lists.
> 3. Click "Add patrons" on an existing list.
> 4. Perform a patron search and choose one of the results.
> 5. Click the "remove" link next to the patron name which was just added.
>    Nothing will happen.
> 
> See also Bug 11534.

As a general observation, interfaces that refer to known patron records would be better off referring to them by borrowernumber, not cardnumber.
Comment 7 Galen Charlton 2014-02-04 18:39:32 UTC
Pushed to master.  Thanks, Owen!
Comment 8 Fridolin Somers 2014-05-16 08:33:47 UTC
Pushed to 3.14.x, will be in 3.14.07