Course reserves templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649.
Created attachment 25146 [details] [review] Bug 11713 - Use new DataTables include in course reserves templates This patch modifies two course reserves templates to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Also included: - Adds a sorting filter on the course reserves detail table to excluding articles from sorting. - Corrects the logic controlling column sorting configuration so that the correct columns have sorting disabled under various combinations of item_level_itypes, CAN_user_coursereserves_delete_reserves, and CAN_user_coursereserves_delete_reserves. - Corrects the styling of toolbar buttons (buttons should have btn and btn-small classes). To test you must have UseCourseReserves enabled and have multiple existing courses, at least one of which should have items on reserve. 1. View the list of courses. Table sorting should work correctly. The "new course" button should look consistent with other staff client toolbar buttons. 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. - Sorting should work correctly, excluding sorting on the Edit, Remove, and "Other course reserves" columns. - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves To test, go to cataloging and choose "New from Z39.50." Perform a search and confirm that table sorting still works correctly.
1. View the list of courses. Table sorting should work correctly. The "new course" button should look consistent with other staff client toolbar buttons. TESTED FINE 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. TESTED FINE - Sorting should work correctly, excluding sorting on the Edit, Remove, and "Other course reserves" columns. TESTED FINE - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. TESTED FINE with item-level_itypes = specific item BROKEN? with item-level_itypes = biblio Course Reserves -> Course Details for NNN101 had sortable arrows on editable. None of the sorting working on other columns. Probably because item type column is not visible and the sort code is misaligned,etc. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves BROKEN? - I added permission for a PT patron add_reserves only checked. Logged in as that patron in staff client. Searched for a book I had reserved. Clicked details and clicked Link to reserves. http://192.168.122.184:8080/cgi-bin/koha/course_reserves/course-details.pl?course_id=1 None of the sort icons worked. (did not pursue combinations at this point). To test, go to cataloging and choose "New from Z39.50." Perform a search and confirm that table sorting still works correctly. TESTED FINE NOTE: I expect this sorting to only apply to staff client.
Created attachment 25865 [details] [review] Bug 11713 - Use new DataTables include in course reserves templates This patch modifies two course reserves templates to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Also included: - Adds a sorting filter on the course reserves detail table to excluding articles from sorting. - Corrects the styling of toolbar buttons (buttons should have btn and btn-small classes). To test you must have UseCourseReserves enabled and have multiple existing courses, at least one of which should have items on reserve. 1. View the list of courses. Table sorting should work correctly. The "new course" button should look consistent with other staff client toolbar buttons. 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. - Sorting should work correctly, excluding sorting on the Edit, Remove, and "Other course reserves" columns. - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves
Created attachment 25949 [details] [review] Bug 11713 - Use new DataTables include in course reserves templates This patch modifies two course reserves templates to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Also included: - Adds a sorting filter on the course reserves detail table to excluding articles from sorting. - Corrects the styling of toolbar buttons (buttons should have btn and btn-small classes). To test you must have UseCourseReserves enabled and have multiple existing courses, at least one of which should have items on reserve. 1. View the list of courses. Table sorting should work correctly. The "new course" button should look consistent with other staff client toolbar buttons. 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. - Sorting should work correctly, excluding sorting on the Edit, Remove, and "Other course reserves" columns. - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 26032 [details] [review] Bug 11713 - Use new DataTables include in course reserves templates This patch modifies two course reserves templates to use the new DataTables include. This simplifies the inclusion of assets and updates to the latest DataTables version. Also included: - Adds a sorting filter on the course reserves detail table to excluding articles from sorting. - Corrects the styling of toolbar buttons (buttons should have btn and btn-small classes). To test you must have UseCourseReserves enabled and have multiple existing courses, at least one of which should have items on reserve. 1. View the list of courses. Table sorting should work correctly. The "new course" button should look consistent with other staff client toolbar buttons. 2. View the list of reserves on a course. - Toolbar buttons should look consistent with other staff client toolbar buttons. - Sorting should work correctly, excluding sorting on the Edit, Remove, and "Other course reserves" columns. - Titles on reserve which begin with an article should be sorted correctly with article excluded - Test sorting with item-level_itypes on and off. - Test sorting using a patron whose permissions include various combinations of add_reserves and delete_reserves Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Owen!
*** Bug 11800 has been marked as a duplicate of this bug. ***
Pushed to 3.14.x, will be in 3.14.07