Bug 11713 - Use new DataTables include in course reserves templates
Summary: Use new DataTables include in course reserves templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 11800 (view as bug list)
Depends on: 11866
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-07 16:28 UTC by Owen Leonard
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11713 - Use new DataTables include in course reserves templates (7.22 KB, patch)
2014-02-07 17:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11713 - Use new DataTables include in course reserves templates (6.41 KB, patch)
2014-03-05 16:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11713 - Use new DataTables include in course reserves templates (6.42 KB, patch)
2014-03-07 18:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11713 - Use new DataTables include in course reserves templates (6.62 KB, patch)
2014-03-10 16:56 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-07 16:28:21 UTC
Course reserves templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2014-02-07 17:32:23 UTC Comment hidden (obsolete)
Comment 2 wajasu 2014-02-24 20:12:24 UTC
1. View the list of courses. Table sorting should work correctly. The
   "new course" button should look consistent with other staff client
   toolbar buttons.
TESTED FINE

2. View the list of reserves on a course.
   - Toolbar buttons should look consistent with other staff client
     toolbar buttons.
TESTED FINE
   - Sorting should work correctly, excluding sorting on the Edit,
     Remove, and "Other course reserves" columns.
TESTED FINE
   - Titles on reserve which begin with an article should be sorted
     correctly with article excluded
   - Test sorting with item-level_itypes on and off.
TESTED FINE with item-level_itypes = specific item
BROKEN?  with item-level_itypes = biblio
Course Reserves -> Course Details for NNN101 had sortable arrows on editable. None of the sorting working on other columns.
Probably because item type column is not visible and the sort code is misaligned,etc.
   - Test sorting using a patron whose permissions include various
     combinations of add_reserves and delete_reserves
BROKEN? - I added permission for a PT patron add_reserves only checked.
Logged in as that patron in staff client.
Searched for a book I had reserved.  Clicked details and clicked Link to reserves.
http://192.168.122.184:8080/cgi-bin/koha/course_reserves/course-details.pl?course_id=1
None of the sort icons worked.
(did not pursue combinations at this point).

To test, go to cataloging and choose "New from Z39.50." Perform a search
and confirm that table sorting still works correctly.
TESTED FINE

NOTE: I expect this sorting to only apply to staff client.
Comment 3 Owen Leonard 2014-03-05 16:18:12 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2014-03-07 18:02:45 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-03-10 16:56:19 UTC
Created attachment 26032 [details] [review]
Bug 11713 - Use new DataTables include in course reserves templates

This patch modifies two course reserves templates to use the new
DataTables include. This simplifies the inclusion of assets and updates
to the latest DataTables version. Also included:

- Adds a sorting filter on the course reserves detail table to excluding
  articles from sorting.
- Corrects the styling of toolbar buttons (buttons should have btn and
  btn-small classes).

To test you must have UseCourseReserves enabled and have multiple
existing courses, at least one of which should have items on reserve.

1. View the list of courses. Table sorting should work correctly. The
   "new course" button should look consistent with other staff client
   toolbar buttons.

2. View the list of reserves on a course.
   - Toolbar buttons should look consistent with other staff client
     toolbar buttons.
   - Sorting should work correctly, excluding sorting on the Edit,
     Remove, and "Other course reserves" columns.
   - Titles on reserve which begin with an article should be sorted
     correctly with article excluded
   - Test sorting with item-level_itypes on and off.
   - Test sorting using a patron whose permissions include various
     combinations of add_reserves and delete_reserves

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Galen Charlton 2014-03-10 17:58:16 UTC
Pushed to master.  Thanks, Owen!
Comment 7 Owen Leonard 2014-03-17 17:06:14 UTC
*** Bug 11800 has been marked as a duplicate of this bug. ***
Comment 8 Fridolin Somers 2014-05-27 14:20:46 UTC
Pushed to 3.14.x, will be in 3.14.07