Bug 11866 - Staff side course reserves too restrictive
Summary: Staff side course reserves too restrictive
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Course reserves (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
: 12248 (view as bug list)
Depends on:
Blocks: 11713
  Show dependency treegraph
 
Reported: 2014-02-27 13:55 UTC by Kyle M Hall
Modified: 2017-09-06 14:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11866 - Staff side course reserves too restrictive (3.75 KB, patch)
2014-02-27 13:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11866 - Staff side course reserves too restrictive (3.85 KB, patch)
2014-03-05 15:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11866 [Follow-up] Staff side course reserves too restrictive (1.53 KB, patch)
2014-03-05 15:58 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11866 [Follow-up] Staff side course reserves too restrictive (1.56 KB, patch)
2014-03-07 18:01 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11866 - Staff side course reserves too restrictive (4.22 KB, patch)
2014-03-10 13:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11866: FIX ergonomic issue (2.94 KB, patch)
2014-03-10 13:57 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-02-27 13:55:13 UTC
A librarian with no course reserves permissions cannot view course reserves from the staff intranet, yet can from the OPAC. This doesn't make much sense. Librarians should not require any course reserves permissions to view courses and reserves from the staff intranet.
Comment 1 Kyle M Hall 2014-02-27 13:57:04 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-02-27 15:29:37 UTC
Kyle I think the change to header.inc should swap the permissions check for a check of the UseCourseReserves system preference. If that pref is turned off, don't show the link.
Comment 3 Owen Leonard 2014-03-05 15:56:44 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2014-03-05 15:58:59 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2014-03-07 18:01:06 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2014-03-10 13:56:55 UTC
Created attachment 26010 [details] [review]
Bug 11866 - Staff side course reserves too restrictive

A librarian with no course reserves permissions cannot view course
reserves from the staff intranet, yet can from the OPAC. This doesn't
make much sense. Librarians should not require any course reserves
permissions to view courses and reserves from the staff intranet.

Test Plan:
1) Log into staff intranet as a librarian with no course reserves
   permissions
2) Note you cannot view course reserves
3) Apply this patch
4) Note you can now view course reserves
5) Verify you cannot modify courses or course reserves

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Bug 11866 [Follow-up] Staff side course reserves too restrictive

This follow-up patch adds a check for the "UseCourseReserves" system
preference to the display of the Course reserves menu item in the
header.

To test, view the "More" menu with the "UseCourseReserves" system
preference on and off. The menu item should appear and disappear
accordingly.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Jonathan Druart 2014-03-10 13:57:03 UTC
Created attachment 26011 [details] [review]
Bug 11866: FIX ergonomic issue

If a user does not have course_reserve permission, a an empty toolbar is
displayed.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2014-03-10 13:58:04 UTC
I squashed 2 first patches for a better readability and submit a small fix for an ergonomic issue.
Comment 9 Owen Leonard 2014-03-10 14:50:03 UTC
(In reply to Jonathan Druart from comment #7)

> If a user does not have course_reserve permission, a an empty toolbar is
> displayed.

I think I fixed this in my patch for Bug 11713
Comment 10 Galen Charlton 2014-03-10 15:03:20 UTC
Pushed to master, along with a follow-up that ensures that a user must have at least the 'catalogue' permission to view the staff-side page.

Thanks, Kyle!
Comment 11 Fridolin Somers 2014-05-27 12:11:17 UTC
Pushed to 3.14.x, will be in 3.14.07
Comment 12 Jonathan Druart 2017-09-06 14:43:09 UTC
*** Bug 12248 has been marked as a duplicate of this bug. ***