Bug 11757 - dependency on POE is not longer necessary
Summary: dependency on POE is not longer necessary
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-14 00:22 UTC by Galen Charlton
Modified: 2015-12-02 23:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 11757: remove dependency on POE (4.68 KB, patch)
2014-02-14 00:30 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 11757: remove dependency on POE (4.71 KB, patch)
2014-02-14 06:50 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11757: remove dependency on POE (4.79 KB, patch)
2014-02-14 14:34 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2014-02-14 00:22:16 UTC
Various modules from the POE family of Perl modules were used by zebraqueue_daemon.pl.  However, as that script was removed per bug 9001, POE is no longer required.
Comment 1 Galen Charlton 2014-02-14 00:30:08 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-14 06:50:32 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-14 14:34:36 UTC
Created attachment 25267 [details] [review]
Bug 11757: remove dependency on POE

The last use of the POE family of Perl modules went away with
the removal of zebraqueue_daemon.pl per bug 9001.  Consequently,
this patch removes POE as a dependency.

To test:

[1] Verify that "git grep POE" and "git grep libpoe" report
    nothing.
[2] Verify that koha_perl_deps.pl -a does not report POE
    as a dependency.
[3] (extra credit) verify that Debian packages can be built
    that do not list libpoe-perl as a dependency.

This patch also updates some distro-specific installation
instructions and scripts, but makes no representations about
whether those instructions currently work.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-15 01:38:36 UTC
Pushed to master.
Comment 5 Fridolin Somers 2014-05-19 14:07:25 UTC
Pushed to 3.14.x, will be in 3.14.07.
Comment 6 Kyle M Hall (khall) 2014-06-06 13:50:49 UTC
Pushed to 3.12.x will be in 3.12.13
Comment 7 David Cook 2015-12-02 23:18:16 UTC
The new work I'm doing for http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662, which hasn't been posted yet, will be using libpoe-perl (and potentially libpoe-component-client-http-perl) for the OAI-PMH harvester daemon.

Galen, how would you like folk to ask for Perl dependencies to be added to Koha?