Bug 11770 - Use validation plugin when creating new road type
Summary: Use validation plugin when creating new road type
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/roadtype.pl?op=ad...
Keywords:
Depends on: 11764 11765
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-14 20:48 UTC by Owen Leonard
Modified: 2014-12-07 20:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11770 - Use validation plugin when creating new road type (4.09 KB, patch)
2014-02-14 21:08 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-14 20:48:46 UTC
The new road type entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-14 21:08:15 UTC
Created attachment 25296 [details] [review]
Bug 11770 - Use validation plugin when creating new road type

The page for adding a new road type includes some custom form
validation JavaScript which can be removed in favor of HTML5 validation
attributes and Koha's built-in validation plugin. This patch does so.

To test, apply the patch and go to Administration -> Road types -> New
road type. Try submitting the form without entering a road type. This
should trigger a validation warning.

Submission of the form with valid data should work correctly. Editing an
existing road type should also work correctly.
Comment 2 Owen Leonard 2014-02-21 16:20:30 UTC
This template no longer exists in master.