Bug 11765 - Remove unused function isDate from templates
Summary: Remove unused function isDate from templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 11764
Blocks: 11766 11767 11769 11770 11771
  Show dependency tree / graph
 
Reported: 2014-02-14 17:52 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11765 - Remove unused function isDate from templates (6.49 KB, patch)
2014-02-14 17:58 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 11765 - Remove unused function isDate from templates (6.52 KB, patch)
2014-02-16 21:24 UTC, Chris Cormack 		Details | Diff | Splinter Review
Bug 11765 - Remove unused function isDate from templates (6.68 KB, patch)
2014-02-17 08:49 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-14 17:52:08 UTC 
Several templates declare a JavaScript function "isDate" but the function is never used.
Comment 1 Owen Leonard 2014-02-14 17:58:58 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-16 21:24:10 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-17 08:49:38 UTC 
Created attachment 25337 [details] [review]
Bug 11765 - Remove unused function isDate from templates

Several administration templates declare but do not use the JavaScript
function isDate(). This patch removes the declarations.

To test, apply the patch and search for instances of "isDate" in Koha
templates, includes, and JavaScript files. There should be no results.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I'm not sure this function has ever been used.
This patch removes the toUC in tools/letter.tt too.
Comment 4 Galen Charlton 2014-02-18 20:52:37 UTC 
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-19 14:15:45 UTC 
Pushed to 3.14.x, will be in 3.14.07