Bug 11771 - Use validation plugin when creating new MARC framework tag
Summary: Use validation plugin when creating new MARC framework tag
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/marctagstructure....
Keywords:
Depends on: 11764 11765
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-14 21:13 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11771 - Use validation plugin when creating new MARC framework tag (5.65 KB, patch)
2014-02-14 21:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11771 - Use validation plugin when creating new MARC framework tag (5.67 KB, patch)
2014-02-16 21:04 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11771 - Use validation plugin when creating new MARC framework tag (5.82 KB, patch)
2014-02-17 10:19 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-14 21:13:50 UTC
The new MARC framework tag entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-14 21:27:37 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-16 21:04:32 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-17 10:19:38 UTC
Created attachment 25342 [details] [review]
Bug 11771 - Use validation plugin when creating new MARC framework tag

The page for adding a new tag to a MARC framework includes some
custom form validation JavaScript which can be removed in favor of HTML5
validation attributes and Koha's built-in validation plugin. This patch
does so.

The patch also moves some tag markup creation out of the script and into
the template where it belongs.

To test, apply the patch and go to Administration -> MARC bibliographic
framework -> MARC structure -> New tag. Try submitting the form without
entering a tag number. This should trigger a validation warning.

Submission of the form with valid data should work correctly. Editing an
existing tag should also work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Great improvement! Before this patch, I got a JS alert but the form was
submitted anyway.
Comment 4 Galen Charlton 2014-02-19 00:04:47 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-19 14:41:34 UTC
Pushed to 3.14.x, will be in 3.14.07