The OverDrive API has changed the way URLs for detail pages and other information is returned; Koha currently prepends http:// to the URLs it receives, but now OverDrive does that themselves, breaking the links.
Created attachment 26497 [details] [review] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct.
Raising importance, as this blocks clicking of links in any OPAC using OverDrive. Good candidate for a maintenance patch.
Created attachment 26856 [details] [review] [SIGNED-OFF] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can reproduce the problem and confirm that this patch fixes it.
Created attachment 26885 [details] [review] [PASSED QA] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can reproduce the problem and confirm that this patch fixes it. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch removes hardcoded http:// from URLs in the Overdrive code. Trusting Jesse and Owen to have tested this with Overdrive, code review reveals no additional changes or possible problems.
Pushed to master. Thanks, Jesse!
Pushed to 3.14.x, will be in 3.14.09