Bug 11978 - OverDrive API now prepends http:// to URLs
Summary: OverDrive API now prepends http:// to URLs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P1 - high major (vote)
Assignee: Jesse Weaver
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-20 17:20 UTC by Jesse Weaver
Modified: 2015-12-03 22:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11978 - Fix URLs displayed in OverDrive search (4.81 KB, patch)
2014-03-20 22:30 UTC, Jesse Weaver
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11978 - Fix URLs displayed in OverDrive search (4.96 KB, patch)
2014-04-07 12:59 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 11978 - Fix URLs displayed in OverDrive search (5.18 KB, patch)
2014-04-07 20:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Weaver 2014-03-20 17:20:18 UTC
The OverDrive API has changed the way URLs for detail pages and other information is returned; Koha currently prepends http:// to the URLs it receives, but now OverDrive does that themselves, breaking the links.
Comment 1 Jesse Weaver 2014-03-20 22:30:11 UTC Comment hidden (obsolete)
Comment 2 Jesse Weaver 2014-03-25 18:23:17 UTC
Raising importance, as this blocks clicking of links in any OPAC using OverDrive. Good candidate for a maintenance patch.
Comment 3 Owen Leonard 2014-04-07 12:59:08 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-04-07 20:00:39 UTC
Created attachment 26885 [details] [review]
[PASSED QA] Bug 11978 - Fix URLs displayed in OverDrive search

OverDrive has recently changed its APIs to include "http://" in the URLs
it returns. This patch removes the "http://" on the Koha end so they
aren't doubled.

Test plan:
  1. Run an OverDrive search on the OPAC.
  2. Check the links, they should start with "http://http://"
  3. Apply this patch.
  4. Rerun the search, the links should now be correct.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I can reproduce the problem and confirm that this patch fixes it.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch removes hardcoded http:// from URLs in the Overdrive code.
Trusting Jesse and Owen to have tested this with Overdrive,
code review reveals no additional changes or possible problems.
Comment 5 Galen Charlton 2014-04-08 23:36:42 UTC
Pushed to master.  Thanks, Jesse!
Comment 6 Fridolin Somers 2014-07-23 15:57:34 UTC
Pushed to 3.14.x, will be in 3.14.09