If you have enhanced messaging preference, the Days in Advance combo value (in Patron Messaging Preferences) is saved in the database but not retrieved when you have not enabled the Email checkbox next to it. This comes from a JOIN that should be a LEFT JOIN.
Created attachment 27234 [details] [review] Bug 12100: Messaging preferences did not save Days in Advance If you have enhanced messaging preference, the Days in Advance combo value (in Patron Messaging Preferences) is saved in the database but not retrieved when you have not enabled the Email checkbox next to it. This patch does the following: [1] It replaces a JOIN by a LEFT JOIN that is the actual reason of the problem described. [2] Removes a FIXME by saving a hardcoded 30 into a constant. [3] Fixes a typo in the neighborhood. [4] Removes a superfluous comma in the map statement. [5] Simplifies code for the selected field of the days combo. It should just be a boolean. The text selected="selected" is in the template. Test plan: [1] Enable enhanced messaging preferences. [2] Fill in Days in advance for Advance notice but uncheck Email. [3] Save the preferences. [4] The member home screen does not display the number of days (until you decide to apply this patch :)
Created attachment 27364 [details] [review] [Signed-off] Bug 12100: Messaging preferences did not save Days in Advance If you have enhanced messaging preference, the Days in Advance combo value (in Patron Messaging Preferences) is saved in the database but not retrieved when you have not enabled the Email checkbox next to it. This patch does the following: [1] It replaces a JOIN by a LEFT JOIN that is the actual reason of the problem described. [2] Removes a FIXME by saving a hardcoded 30 into a constant. [3] Fixes a typo in the neighborhood. [4] Removes a superfluous comma in the map statement. [5] Simplifies code for the selected field of the days combo. It should just be a boolean. The text selected="selected" is in the template. Test plan: [1] Enable enhanced messaging preferences. [2] Fill in Days in advance for Advance notice but uncheck Email. [3] Save the preferences. [4] The member home screen does not display the number of days (until you decide to apply this patch :) Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 27627 [details] [review] [PASSED QA] Bug 12100: Messaging preferences did not save Days in Advance If you have enhanced messaging preference, the Days in Advance combo value (in Patron Messaging Preferences) is saved in the database but not retrieved when you have not enabled the Email checkbox next to it. This patch does the following: [1] It replaces a JOIN by a LEFT JOIN that is the actual reason of the problem described. [2] Removes a FIXME by saving a hardcoded 30 into a constant. [3] Fixes a typo in the neighborhood. [4] Removes a superfluous comma in the map statement. [5] Simplifies code for the selected field of the days combo. It should just be a boolean. The text selected="selected" is in the template. Test plan: [1] Enable enhanced messaging preferences. [2] Fill in Days in advance for Advance notice but uncheck Email. [3] Save the preferences. [4] The member home screen does not display the number of days (until you decide to apply this patch :) Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master, along with a follow-up that fixes a regression on bug 5603 introduced by the main patch. Thanks, Marcel!