When using the CSV export option for late serial issues, the claim date is set, but the claimed status for the issue isn't. The issue remains as late.
Please test bug 5342. I can provide a fix for serial claims, but on top of bug 5342.
Created attachment 38607 [details] [review] Bug 12178: Update serial status to "claimed" when exporting to CSV On the same way as late issues, the serial status should be updated to 'claimed' when the issues as exported as csv. QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the same thing, I kick the second on off to centralize the code. Test plan: 1/ Export some late issues as CSV (serials/claims.pl). 2/ Refresh the page (the export does not do it) and confirm that the status, the claim date and the claim count have been updated. 3/ Select some others issues, select a notice and send the notification. Confirm that the behavior is the same.
A promise is a promise
I tried to fix the conflict, but I wasn't sure of the changes in C4::Serials I will try to sign off again if you fix the conflicts.
Created attachment 45983 [details] [review] Bug 12178: Update serial status to "claimed" when exporting to CSV On the same way as late issues, the serial status should be updated to 'claimed' when the issues as exported as csv. QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the same thing, I kick the second on off to centralize the code. Test plan: 1/ Export some late issues as CSV (serials/claims.pl). 2/ Refresh the page (the export does not do it) and confirm that the status, the claim date and the claim count have been updated. 3/ Select some others issues, select a notice and send the notification. Confirm that the behavior is the same.
Tested on sandbox test14 No changes on claim status, claim date nor claim count after exporting csv. In koha error logs : lateissues-export.pl: DBD::mysql::db do failed: Unknown column 'CLAIMED' in 'field list'
Created attachment 49559 [details] [review] Bug 12178: Update serial status to "claimed" when exporting to CSV On the same way as late issues, the serial status should be updated to 'claimed' when the issues as exported as csv. QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the same thing, I kick the second on off to centralize the code. Test plan: 1/ Export some late issues as CSV (serials/claims.pl). 2/ Refresh the page (the export does not do it) and confirm that the status, the claim date and the claim count have been updated. 3/ Select some others issues, select a notice and send the notification. Confirm that the behavior is the same.
Created attachment 51732 [details] [review] Bug 12178: Tests for changes to claimed serial status
Added and attached tests for the method C4::Serial->updateClaim(). Serials/claims.pl now updates the serial status and claim count similarly when exporting to csv or sending a notification - as described in the test plan.
The second patch includes patches that depend on the setting of the dateformat system preference - it has to be set to dd/mm/yyyy to work. It would be better to fix this.
See last comment (fix required) But also a question: Would it be possible to reload the page? I accidentally ended up with 2 claims, where I was not sure it had worked before. I think this could be a trap a lot of libraries fall into.
Created attachment 52637 [details] [review] Bug 12178: Update serial status to "claimed" when exporting to CSV On the same way as late issues, the serial status should be updated to 'claimed' when the issues as exported as csv. QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the same thing, I kick the second on off to centralize the code. Test plan: 1/ Export some late issues as CSV (serials/claims.pl). 2/ Refresh the page (the export does not do it) and confirm that the status, the claim date and the claim count have been updated. 3/ Select some others issues, select a notice and send the notification. Confirm that the behavior is the same.
Created attachment 52638 [details] [review] Bug 12178: Tests for changes to claimed serial status Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Remove trailing spaces
Created attachment 52639 [details] [review] Bug 12178: Fix tests not to depend on dateformat syspref
(In reply to Katrin Fischer from comment #11) > But also a question: Would it be possible to reload the page? I accidentally > ended up with 2 claims, where I was not sure it had worked before. I think > this could be a trap a lot of libraries fall into. It should be possible yes.
Created attachment 52801 [details] [review] Bug 12178: Update serial status to "claimed" when exporting to CSV On the same way as late issues, the serial status should be updated to 'claimed' when the issues as exported as csv. QA note: The updateClaim and UpdateClaimdateIssues subroutine did almost the same thing, I kick the second on off to centralize the code. Test plan: 1/ Export some late issues as CSV (serials/claims.pl). 2/ Refresh the page (the export does not do it) and confirm that the status, the claim date and the claim count have been updated. 3/ Select some others issues, select a notice and send the notification. Confirm that the behavior is the same. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 52802 [details] [review] Bug 12178: Tests for changes to claimed serial status Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: Remove trailing spaces Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 52803 [details] [review] Bug 12178: Fix tests not to depend on dateformat syspref Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Jonathan Druart from comment #15) > (In reply to Katrin Fischer from comment #11) > > But also a question: Would it be possible to reload the page? I accidentally > > ended up with 2 claims, where I was not sure it had worked before. I think > > this could be a trap a lot of libraries fall into. > > It should be possible yes. Is it done?
I think this can go back to passed qa
Pushed to master for 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.02.
Patches pushed to 3.22.x, will be in 3.22.10