Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page
Summary: Serial claims: claiming via CSV export doesn't reload the page
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 12178
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-24 14:39 UTC by Katrin Fischer
Modified: 2018-04-18 18:48 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page (1.63 KB, patch)
2016-06-24 14:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page (1.77 KB, patch)
2016-08-01 17:13 UTC, Frédéric Demians
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2016-06-24 14:39:51 UTC
When using the CSV export for claiming serial issues, with bug 12178 the claim counter is incremented and a claim date set, but this will only be visible after reloading the page manually as the feature itself doesn't reload the page.

To avoid confusion and errors using this feature,, the page should reload when the claims data is changed.
Comment 1 Kyle M Hall 2016-06-24 14:56:08 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2016-08-01 17:13:04 UTC
Created attachment 53855 [details] [review]
Bug 16808 - Serial claims: claiming via CSV export doesn't reload the page

When using the CSV export for claiming serial issues, with bug 12178 the
claim counter is incremented and a claim date set, but this will only be
visible after reloading the page manually as the feature itself doesn't
reload the page.

To avoid confusion and errors using this feature,, the page should
reload when the claims data is changed.

Test Plan:
1) Claim some serials
2) Note the page does not reload, the status is not set to 'claimed'
3) Apply this patch
4) Claim some serials
5) Note the page reloads and verify that the status of the selected
   serials are "claimed"

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Comment 3 Katrin Fischer 2016-08-01 22:11:24 UTC
The way this patch works creates a warning about resending the page in Firefox 47 (mine is German, so copying the message here probably won't help much).
This might turn some users away thinking it's a bug, especially since the message appears before the download with a warning sound. Is there a better way to achieve that? Could we not just reload the page like other forms do?
Comment 4 Katrin Fischer 2016-08-01 22:12:52 UTC
The warning reads something like this: this will make firefox reload the page and will cause all actions to be repeated (like a search or an ordering process)
Comment 5 Josef Moravec 2016-11-03 08:47:19 UTC
We could change the vendor selecting form method from post to get - it should allow to avoid this message...
Comment 6 Katrin Fischer 2017-08-15 20:19:37 UTC
I've tested by changing to GET and the error message in Firefox remains.
Could we trigger relaod of the page server side? Use Ajax?