Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status
Summary: Catalog details page displaying incorrect status for items with itemtype leve...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-22 10:36 UTC by Kyle M Hall
Modified: 2015-06-04 23:33 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status (2.48 KB, patch)
2014-05-22 10:41 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status (2.55 KB, patch)
2014-07-03 15:15 UTC, Nick Clemens
Details | Diff | Splinter Review
[PASSED QA] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status (2.65 KB, patch)
2014-07-06 18:37 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-05-22 10:36:46 UTC
The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag.
Comment 1 Kyle M Hall 2014-05-22 10:41:39 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-06-18 14:37:00 UTC
This looks similar than bug 12419 (but not the same view).
Comment 3 Koha Team University Lyon 3 2014-06-19 08:47:39 UTC
We didn't understand the bug to be fixed, we could not manage to see the bug on the master version  in english, we give up. The bug should be explained with more details.
Comment 4 Jonathan Druart 2014-06-19 08:59:41 UTC
(In reply to Koha Team Lyon 3 from comment #3)
> We didn't understand the bug to be fixed, we could not manage to see the bug
> on the master version  in english, we give up. The bug should be explained
> with more details.

See with Lyon 3, the item-level_itypes pref should be set to "item specific". They use "biblio record", so they won't test this patch.

But no regression found for biblio level :)
Comment 5 Nick Clemens 2014-07-03 15:15:36 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-07-06 18:37:27 UTC
Created attachment 29527 [details] [review]
[PASSED QA] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status

The template markup that controls that status column for
the items table in catalogue/detail.pl does not account
for the itemtypes.notforloan flag.

Test Plan:
1) Find an item that is currently available
2) Go to the itemtype editor and mark that itemtype of that item
   as being not for loan
3) Browse to the catalog details page for that item's record
4) Note the item status is still "Available"
5) Apply this patch
6) Reload the catalog details page
7) Note the item status is now "Not for loan"

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Good catch! Works as described, no problems found.
Comment 7 Tomás Cohen Arazi 2014-07-11 19:30:29 UTC
Patch pushed to master.

Thanks Brendan!