Bug 12419 - Not for loan items are not listed
Summary: Not for loan items are not listed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 13:27 UTC by Jonathan Druart
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12419: Not for loan items are not listed (3.69 KB, patch)
2014-06-13 13:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12419: Not for loan items are not listed (3.74 KB, patch)
2014-06-18 20:22 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 12419: Not for loan items are not listed (3.87 KB, patch)
2014-06-21 16:40 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 12419: (QA followup) regression tests (4.28 KB, patch)
2014-06-30 18:48 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 12419: (QA followup) regression tests (5.42 KB, patch)
2014-06-30 18:56 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-06-13 13:27:35 UTC
On the cataloguing search (cataloguing/addbook.pl), if an item has a notforloan value > 0, the item is not listed in the Location column.

It is quite confusing, the current behavior let patrons believe that there is not item for the biblio (or less than the real count).
Comment 1 Jonathan Druart 2014-06-13 13:30:56 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-06-13 13:31:36 UTC
I'am not sure at all that is the best way to fix this issue. Ideas welcomed.
Comment 3 Nicole C. Engard 2014-06-18 20:22:20 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-06-21 16:40:12 UTC
Created attachment 29135 [details] [review]
[PASSED QA] Bug 12419: Not for loan items are not listed

On the cataloguing search (cataloguing/addbook.pl), if an item has a
notforloan value > 0, the item is not listed in the Location column.

It is quite confusing, the current behavior let patrons believe that
there is not item for the biblio (or less than the real count).

Test plan:
1/ Create 2 biblio records A and B
2/ Create some items for A
3/ Create 1+ item(s) for B with a notforloan status > 0
4/ Reindex both records
5/ Launch a search on the cataloguing module and verify that the
notforloan items are not listed in the 'Location' column.
6/ Apply this patch and verify the not for loan items are listed ("Not
for loan (XXX)").

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script, not for loan items now show up.
Comment 5 Tomás Cohen Arazi 2014-06-30 18:48:20 UTC Comment hidden (obsolete)
Comment 6 Tomás Cohen Arazi 2014-06-30 18:56:42 UTC
Created attachment 29385 [details] [review]
Bug 12419: (QA followup) regression tests

Changes to searchResults deserve unit tests.

Edit: minor tweaks:
 - Remove warning in line 702
 - Modernize
 - License added
 - "This file is a stub" removed

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 7 Tomás Cohen Arazi 2014-06-30 18:58:59 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 8 Galen Charlton 2014-09-23 20:46:06 UTC
Pushed to 3.16.x for inclusion in 3.16.4.