Created attachment 28867 [details] FU showing in OPAC In the past the patron did not see the Fines code (FU, F, etc) - but they do now and it's confusing and a bit insulting in US English. Can we have FU just say Fine or not appear at all to the public?
Caused by Bug 2546 which attempts to anticipate every obscure undocumented account type code which Koha uses but fails to cover all of them: [% SWITCH line.accounttype %] [% CASE 'Pay' %]Payment,thanks [% CASE 'Pay00' %]Payment,thanks (cash via SIP2) [% CASE 'Pay01' %]Payment,thanks (VISA via SIP2) [% CASE 'Pay02' %]Payment,thanks (credit card via SIP2) [% CASE 'N' %]New Card [% CASE 'F' %]Fine [% CASE 'A' %]Account management fee [% CASE 'M' %]Sundry [% CASE 'L' %]Lost Item [% CASE 'W' %]Writeoff [% CASE %][% line.accounttype %] [%- END -%] Kyle's list of codes includes these which are not in the above list: FU = Fine that is currently accruing Rent = Rental fee FOR = Forgiven LR = Lost item fee refund PAY = Payment WO = Writeoff C = Credit CR = Credit I also see checks in the code for accounttypes 'O' and 'FN' but I haven't found any code which inserts those codes.
Created attachment 29334 [details] [review] Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details -> Fines) and the pay fines page (Patron details -> Fines -> Pay fines). You should not see any account type codes like CR, LR, or FU.
Created attachment 29369 [details] [review] Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details -> Fines) and the pay fines page (Patron details -> Fines -> Pay fines). You should not see any account type codes like CR, LR, or FU.
Created attachment 29370 [details] [review] Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the "Your fines" page. You should not see any account type codes like CR, LR, or FU.
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Created attachment 29389 [details] [review] Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details -> Fines) and the pay fines page (Patron details -> Fines -> Pay fines). You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 29390 [details] [review] Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the "Your fines" page. You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 29531 [details] [review] [PASSED QA] Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details -> Fines) and the pay fines page (Patron details -> Fines -> Pay fines). You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 29532 [details] [review] [PASSED QA] Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the "Your fines" page. You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patches pushed to master. Thanks Owen!
Are there any plans for this to be in 3.16.x?
Couple of small issues still need to be addressed: * The code 'FFOR' is still not expanded. * There is a space between the fine decription and the following comma, so Fine , To kill a mockingbird / 10/23/2013 23:59 View item To kill a mockingbird / should read Fine, To kill a mockingbird / 10/23/2013 23:59 View item To kill a mockingbird /
Pushed to 3.16.x for inclusion in 3.16.4.