---- Reported by nicolas.morin@biblibre.com 2008-08-22 03:35:59 ---- In boraccount.pl / fines / account tab, the texts in the Description of charges column seem to be directly taken from the database, and thus cannot be translated: Writeoff, Account Management fee, etc. ---- Additional Comments From nicolas.morin@biblibre.com 2008-10-07 02:02:41 ---- Correction: the strings are not coming from the db, they're quite simply hardcoded in the template: intranet-tmpl/prog/en/modules/members/maninvoice.tmpl ---- Additional Comments From nengard@gmail.com 2009-12-23 17:59:26 ---- This bug hasn't been touched in nearly a year, please revisit and test and close if appropriate. ---- Additional Comments From nicolas.morin@biblibre.com 2009-12-28 10:54:48 ---- in C4/accounts.pm sub manualinvoice shouldn't directly write the description in the DB, only the type, because the 2 informations are redundant: $type eq 'F' / $desc .= " Fine"; Next: the template should be the one writing the information. But since the template toolkit we ues can't really compare if value = F, we have to pass all the possible values as booleans to the tmpl --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:52 UTC --- This bug was previously known as _bug_ 2546 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2546 Actual time not defined. Setting to 0.0 The original reporter of this bug does not have an account here. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. Previous reporter was nicolas.morin@biblibre.com. CC member nicolas.morin@biblibre.com does not have an account here
Created attachment 2243 [details] opac screenshot This is not only a problem in staff but also in opac. The English descriptions are confusing for patrons. (see screenshot)
*** Bug 2188 has been marked as a duplicate of this bug. ***
Created attachment 3070 [details] screenshot This problem still exists in current master and 3.2.x branch. See updated screenshot.
Christophe will: * display the accountlines.accounttype column in the html table, expanding the code to display the full term, not only the code itself -and doing this in the template, to have a translatable string * remove Accounts.pm/manualinvoice sub, lines 356 & following that add the non translatable string into desc At the end: * description will be only manually entered * type will be displayed Possible values for accounttype: N=New Card F=Fine A=Account Management fee M=Sundry L=Lost Item
10 months later this is still a major problem, so I guess it was not really assigned to Christophe, so i'm resetting to NEW.
Created attachment 22307 [details] [review] Bug 2546: Description of charges is not translatable The descriptions for charges are stored in English in the DB (accounlines.description). So there are not translatable. This patch removes the descriptions automatically added and generates the string in the template. Test plan: 1/ Execute the updatedatabase entry. 2/ Verify in the following pages the description is consistent: - members/pay.pl?borrowernumber=XXXX - members/boraccount.pl?borrowernumber=XXXX - opac-readingrecord.pl 3/ Launch the translate script and update the po files in order to translate the new strings. 4/ Verify the strings are translated in the interface.
Created attachment 22351 [details] [review] Bug 2546: Description of charges is not translatable The descriptions for charges are stored in English in the DB (accountlines.description). So they are not translatable. This patch removes the descriptions automatically added and generates the string in the template. Test plan: 1/ Execute the updatedatabase entry. 2/ Verify in the following pages the description is consistent: - members/pay.pl?borrowernumber=XXXX - members/boraccount.pl?borrowernumber=XXXX - opac-account.pl 3/ Launch the translate script and update the po files in order to translate the new strings. 4/ Verify the strings are translated in the interface. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Works as advertised. Corrected few typos in the commit message.
I was looking at the updatedatabase.pl portion of the diff. What descriptions aren't updated? Why is the table not altered and the description column just dropped?
(In reply to M. Tompsett from comment #8) > I was looking at the updatedatabase.pl portion of the diff. What > descriptions aren't updated? Why is the table not altered and the > description column just dropped? The description may contain your typed-in comments etc. We cannot drop it. Go to Fines and pay something just to see..
Created attachment 23079 [details] [review] Bug 2546: Description of charges is not translatable The descriptions for charges are stored in English in the DB (accountlines.description). So they are not translatable. This patch removes the descriptions automatically added and generates the string in the template. Test plan: 1/ Execute the updatedatabase entry. 2/ Verify in the following pages the description is consistent: - members/pay.pl?borrowernumber=XXXX - members/boraccount.pl?borrowernumber=XXXX - opac-account.pl 3/ Launch the translate script and update the po files in order to translate the new strings. 4/ Verify the strings are translated in the interface. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Works as advertised. Corrected few typos in the commit message. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Bug 6427 will also obviate this issue. I believe it will be pushed to master before the 3.16 release, and would recommend *not* pushing this patch to master. However, it should definitely be pushed for 3.14.x and earlier.
(In reply to Kyle M Hall from comment #11) > Bug 6427 will also obviate this issue. I believe it will be pushed to master > before the 3.16 release, and would recommend *not* pushing this patch to > master. However, it should definitely be pushed for 3.14.x and earlier. The accounts rewrite is still very much a work in progress and will require more discussion and testing, so it is premature to consider it a blocker for patches that implement current fixes -- particularly as it is preferable that patches destined for backporting to a maintenance branch show up in master first. I don't see anything in Jonathan's patch that blocks anything proposed by the accounts rewrite. If there is something, Kyle, this is your opportunity to speak up about it (although since you have already indicated that you believe it suitable for maintenance branches, I would assume that you don't know of any such blocker).
Agreed. Perhaps I'm being too optimistic ; ) (In reply to Galen Charlton from comment #12) > (In reply to Kyle M Hall from comment #11) > > Bug 6427 will also obviate this issue. I believe it will be pushed to master > > before the 3.16 release, and would recommend *not* pushing this patch to > > master. However, it should definitely be pushed for 3.14.x and earlier. > > The accounts rewrite is still very much a work in progress and will require > more discussion and testing, so it is premature to consider it a blocker for > patches that implement current fixes -- particularly as it is preferable > that patches destined for backporting to a maintenance branch show up in > master first. > > I don't see anything in Jonathan's patch that blocks anything proposed by > the accounts rewrite. If there is something, Kyle, this is your opportunity > to speak up about it (although since you have already indicated that you > believe it suitable for maintenance branches, I would assume that you don't > know of any such blocker).
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.14.x, will be in 3.14.1 (creates DBRev 3.14.00.003)
It looks like this needs a follow up for bootstrap! (bug 12165)