Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully.
Created attachment 29674 [details] [review] Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table
This doesn't work for me. After I submit some renewals and the page reloads I don't see any messages.
I don't think we need more messages to appear on the screen that then disappear or are ignored, the fact that the renewal was successful just needs to be more clear on the patron's summary tab in the OPAC or the patron's Check Out tab in the Staff Client with the text saying 'RENEWED' instead of 'NOT RENEWABLE'. Also if there must be text below that, then could it say just '1 renewal remaining' or '0 renewal remaining' instead of '1 of 1...' or '0 of 1...' which is confusing and not helpful.
Created attachment 29926 [details] Demonstration Video Not sure what's going wrong for you. I just applied the patch to a fresh install and made this video. No changes to the patch were needed.
Patch tested with a sandbox, by Cathi Wiggins <cwiggins@ci.arcadia.ca.us>
Created attachment 30008 [details] [review] Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Signed-off-by: Cathi Wiggins <cwiggins@ci.arcadia.ca.us>
I am sorry, but the new message is not showing up for me, I have double checked: Patch is applied, looking at bootstrap, looking at English templates... I don't see where this is going wrong.
Asked Bernardo to give it a try too - he can't see the new message either. Please take a look.
Problem seems to be related with '|' to concat/split itemnumbers, Changing that to '_' or ':' works perl -e ' use Data::Dumper; $a="10_20"; @b = split ("_", $a) ; print Dumper \@b;' $VAR1 = [ '10', '20' ]; perl -e ' use Data::Dumper; $a="10"; @b = split ("_", $a) ; print Dumper \@b;' $VAR1 = [ '10' ]; perl -e ' use Data::Dumper; $a="10|20"; @b = split ("|", $a) ; print Dumper \@b;' $VAR1 = [ '1', '0', '|', '2', '0' ]; -------------------> BAD ! perl -e ' use Data::Dumper; $a="10:20"; @b = split (":", $a) ; print Dumper \@b;' $VAR1 = [ '10', '20' ]; Now, when fixed the button/message is a bit large and ugly, that's another problem :)
Created attachment 30085 [details] [review] Bug 12568 [QA Followup] - Use ':' as separator instead of '|'
(In reply to Bernardo Gonzalez Kriegel from comment #9) > Problem seems to be related with '|' to concat/split itemnumbers, > Changing that to '_' or ':' works Thanks for finding that out! Followup attached! > > Now, when fixed the button/message is a bit large and ugly, that's another > problem :) Well, the idea *is* to make the renewal very prominent ; ) This is also the standard bootstrap style alert which we have been preferring in the bootstrap theme.
(In reply to Kyle M Hall from comment #11) > Well, the idea *is* to make the renewal very prominent ; ) This is also the > standard bootstrap style alert which we have been preferring in the > bootstrap theme. Yes, and it looks better on a screen as wide as that of your video :)
Created attachment 30181 [details] [review] [PASSED QA] Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Signed-off-by: Cathi Wiggins <cwiggins@ci.arcadia.ca.us> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Makes successful renewals more visible to the user in the OPAC.
Created attachment 30182 [details] [review] [PASSED QA] Bug 12568 [QA Followup] - Use ':' as separator instead of '|' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Pushed to MM_OPAC/bug_12568
Patches pushed to master. Thanks Kyle!